-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site settings don't get saved #17859
Comments
Latest update: 14:50, 5th of September Possibly related to brave/brave-core#9940. The fix is part of the upcoming release, I believe we're hours away from it. @goodov is there any possibility that this issue is related to the ephemeral storage changes you introduced in
|
It looks like something is going on with |
Thank you for taking a look @goodov! I asked users in |
It looks like Please, take a look at the following thread for more details: The issue is not exclusive to ItzMeRajat from
|
@Tonev Can you share some additional info if possible please?
|
I received user's permission to upload the recording after I removed the sensitive information. Recording.online-video-cutter.com.mp4Used extensions: https://aws1.discourse-cdn.com/brave/original/3X/0/f/0f975afe4c9f82a1b9ba23dc66d9a6b53a70fc2b.png
|
Thank you. As it's not quite clear what is the root cause of the problem right now, the temporary solution is to disable "Enable Ephemeral Storage" feature on |
Just to let you know, I updated my last comment by including user's extensions. Also, he confirmed that disabling I told other users to disable Will keep you updated should users report additional details that could be of help. Good luck in debugging the issue 😃 |
@Tonev Thank you! |
Rajat quickly tested I asked other users to give |
@goodov I had the same issue on 1.29.76 but updated to 1.29.77 and (My issue was localStorage being wiped on tab close, not on refresh) EDIT: After a while it seems the problem is back again |
Are you able to reproduce the issue in Also, did you disable
|
Feedly and pocket worked today without any problems. Version 1.29.76 |
Do you mean |
Nope. Still on .76 |
I didn't disable brave://flags/#brave-ephemeral-storage before. But I've been trying it for hours and so far it's working okay, no issues, I guess it really is related to this setting. |
and logged out of feedly and settings of pocket reset again. Still on .76 |
Latest update: 08:50, 6th of September Disable Another thread in Pay attention especially to the following:
I begin to think that the issue is random and that it doesn't affect all Brave users. The troublesome part is finding out why some Brave users are affected by
|
Latest update: 09:07, 6th of September It looks like users are also having issues with clearing their browsing data. As per https://community.brave.com/t/discord-logging-out-automatically/277284:
As per https://community.brave.com/t/login-and-cookie-problems/279752:
I got a confirmation that disabling the flag allows users to clear their browsing data.
|
UPDATE We are now unsure if the error still exists. We toggled the Ephemeral Storage to disabled, restarted Brave, checked (worked fine), changed back to Default settings on Ephemeral Storage, restarted, still works. We can't tell you what exactly "fixed" it. I send you a message when the error appears again. We're having the same issue on the latest Brave Version on two developer notebooks:
After updating the (1) M1 Mac to 1.29.77, the dev says the localstorage is again available. When I disable the flag brave://flags/#brave-ephemeral-storage it works as expected. How to reproduce this:
With disabled Ephemeral Storage on machine (2) it works again as expected. |
Latest update: 08:40, 7th of September
I got multiple reports that the issue disappears when the flag is enabled but unfortunately it would return sooner or later and users will have to disable the flag. Concrete examples:
|
Thanks for the assistance @Tonev 😄 @goodov has a fix and we're assessing it now (creating test plan that proves the fix works, testing that, seeing if this is a problem on Android too, etc). This is marked as a P1 - so we'll be chatting in a bit (as part of the assessment) about releasing a hotfix. Thanks for your patience folks 😄 |
Happy to help, @bsclifton.
Since the issue was reported here, I've been updating my comments here all the time so they're all up to date. If you think the I don't know if the issue is present on Android too, but since I got a confirmation that disabling the flag resolves the issue with clearing browsing data (#17859 (comment)), a user in Anyway, best of luck pushing a fix and thanks for everyone's work 😉 |
Unfortunately this seems difficult to reproduce as mentioned above several times. It seems like some users can reproduce the issue after a few hours and certain users can't. I personally ran through a few cases and couldn't reproduce the issue using
@brave/legacy_qa run through the above several times to make sure the above is still working and nothing obvious regressed. |
Closing the issue and moving it into https://github.com/brave/brave-browser/milestone/232. |
Despite of this issue had been closed, I think that this might help. In my case happen after some time to use the browser and after I open at least 6 tabs. This happen on youtube and also on discord. #issuecomment-914832612 Version 1.29.77 Chromium: 93.0.4577.63 (Official Build) (64-bit) |
Version 1.29.77 Chromium: 93.0.4577.63 (Official Build) (64-bit) Youtube, tutanota.com, startmail.com and more also. |
Verification is passed on
Additional casesCase 1_Enable Ephemeral Storage flag and verify site settings
(Verified the steps 1-8 without enabling
Case 2_Login gmail, view emails and verify site settings
Case 3_View twitch videos, change settings and verify site settings retain
Case 4_Clear cookies and site data verify site settings retain
Verified passed with
Verification passed on
|
Verification passed on Oppo Reno 5 with Android 11 running 1.29.79 x64 build
|
Might be a good idea to correct the mistake in the ticket's title so the release notes are fetched correctly 😄 CC: @LaurenWags |
We usually translate each issue to something that people can understand either way. We usually don't use the title as the release notes. For example, for this issue, we used the following:
Example of the release notes: |
Just a heads up, we just released https://github.com/brave/brave-browser/releases/tag/v1.29.79 on all platforms which should fix the issue that users were experiencing. If you're still experiencing the issue while using |
Please, take a look when possible: |
I'm not sure if it's the same issue for harrythunder, it might be something cookie related. Let's wait for other users to confirm whether the issue reappears for them or not. |
What bothers me in user's report is that the user claims disabling ephemeral storage resolves the issue. It could be temporarily, though, I'll keep you updated. |
Since the update site settings don't get saved.
Logs me out of feedly, have to set pocket viewing options again, brave search every time shows this "Search results quality and coverage vary by country
We are working hard to improve them all. Thanks for trusting us."
Other users reported it here: https://www.reddit.com/r/brave_browser/comments/ph1vgl/site_settings_doesnt_get_saved/
The text was updated successfully, but these errors were encountered: