Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to leave sync chain when offline #18054

Closed
AlexeyBarabash opened this issue Sep 13, 2021 · 2 comments · Fixed by brave/brave-core#10044
Closed

Allow to leave sync chain when offline #18054

AlexeyBarabash opened this issue Sep 13, 2021 · 2 comments · Fixed by brave/brave-core#10044
Assignees
@AlexeyBarabash
Labels
feature/sync OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
1.31.x - Release

Comments

@AlexeyBarabash
Copy link
Contributor

Description

Allow to leave sync chain when offline. If server does not replies on delete device for a certain amount of time, perform forced leave sync chain.
@AlexeyBarabash AlexeyBarabash self-assigned this Sep 13, 2021
@AlexeyBarabash AlexeyBarabash mentioned this issue Sep 13, 2021
Merged
24 tasks
AlexeyBarabash added a commit to brave/brave-core that referenced this issue Sep 16, 2021
@AlexeyBarabash
Leave sync chain after 5 seconds without ack response
2419107 
fixes brave/brave-browser#18054
AlexeyBarabash added a commit to brave/brave-core that referenced this issue Sep 16, 2021
@AlexeyBarabash
Leave sync chain after 5 seconds without ack response
f542981 
fixes brave/brave-browser#18054
@AlexeyBarabash AlexeyBarabash added this to the 1.31.x - Beta milestone Sep 17, 2021
@stephendonner
Copy link

stephendonner commented Sep 20, 2021 •
edited by GeetaSarvadnya
Loading

Verified PASSED using

Brave 1.31.54 Chromium: 94.0.4606.50 (Official Build) beta (x86_64)
Revision 0c1ac2c4842a4746c27c937c1a0453f98da1a972-refs/branch-heads/4606@{#1049}
OS macOS Version 11.6 (Build 20G165)

Steps:

  1. new profile
  2. launched Brave
  3. clicked on the “hamburger” menu
  4. chose Sync
  5. clicked on Start a new Sync Chain
  6. clicked on Computer
  7. clicked OK
  8. disconnected Wi-Fi
  9. went to Manage your synced devices (brave://settings/braveSync/setup)
  10. clicked Leave Sync Chain
  11. device should leave sync in 5 seconds
  12. opened in brave://sync-internals; confirmed Transport State is Disabled
  13. confirmed device is gone from brave://settings/braveSync/setup
example example example example
Screen Shot 2021-09-20 at 12 15 03 PM Screen Shot 2021-09-20 at 12 18 18 PM Screen Shot 2021-09-20 at 12 18 45 PM Screen Shot 2021-09-20 at 12 19 22 PM

Verified PASSED using

Brave 1.31.64 Chromium: 94.0.4606.61 (Official Build) beta (64-bit)
Revision 418b78f5838ed0b1c69bb4e51ea0252171854915-refs/branch-heads/4606@{#1204}
OS Linux

Steps:

  1. new profile
  2. launched Brave
  3. clicked on the “hamburger” menu
  4. chose Sync
  5. clicked on Start a new Sync Chain
  6. clicked on Computer
  7. clicked OK
  8. disconnected Wi-Fi
  9. went to Manage your synced devices (brave://settings/braveSync/setup)
  10. clicked Leave Sync Chain
  11. device should leave sync in 5 seconds
  12. opened in brave://sync-internals; confirmed Transport State is Disabled
  13. confirmed device is gone from brave://settings/braveSync/setup
example example example example
Screen Shot 2021-09-28 at 4 30 31 PM Screen Shot 2021-09-28 at 4 31 12 PM Screen Shot 2021-09-28 at 4 34 07 PM Screen Shot 2021-09-28 at 4 33 57 PM

Verification passed on

Brave | 1.31.66 Chromium: 94.0.4606.61 (Official Build) beta (64-bit)
-- | --
Revision | 418b78f5838ed0b1c69bb4e51ea0252171854915-refs/branch-heads/4606@{#1204}
OS | Windows 10 Version 21H1 (Build 19043.1237)

Steps:

  1. new profile
  2. launched Brave
  3. clicked on the “hamburger” menu
  4. chose Sync
  5. clicked on Start a new Sync Chain
  6. clicked on Computer
  7. clicked OK
  8. disconnected Wi-Fi
  9. went to Manage your synced devices (brave://settings/braveSync/setup)
  10. clicked Leave Sync Chain
  11. device should leave sync in 5 seconds
  12. opened in brave://sync-internals; confirmed Transport State is Disabled
  13. confirmed device is gone from brave://settings/braveSync/setup
example example example example
image image image image

@srirambv
Copy link
Contributor

srirambv commented Oct 5, 2021

Verification passed on Oppo Reno 5 with Android 11 running 1.31.67 x64 Beta build

  • Verified test plan from Leave sync chain after 5 seconds without ack response brave-core#10044
  • Verified when device is offline able to remove device from sync chain via the delete button
  • Verified chrome://sync-internals shows Transport State: Disabled
  • Verified reconnecting the device to networks doesn't turn sync on again and transport status remains disabled

Verification passed on Samsung Tab A with Android 10 running 1.31.67 x64 Beta build

  • Verified test plan from Leave sync chain after 5 seconds without ack response brave-core#10044
  • Verified when device is offline able to remove device from sync chain via the delete button
  • Verified chrome://sync-internals shows Transport State: Disabled
  • Verified reconnecting the device to networks doesn't turn sync on again and transport status remains disabled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexeyBarabash AlexeyBarabash

Labels
feature/sync OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.31.x - Release
Development

Successfully merging a pull request may close this issue.

Leave sync chain after 5 seconds without ack response brave/brave-core
5 participants
@stephendonner @srirambv @AlexeyBarabash @LaurenWags @GeetaSarvadnya