Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

component resources have organizational and dependency issues #1808

Closed
bridiver opened this issue Oct 23, 2018 · 2 comments · Fixed by brave/brave-core#719
Closed

component resources have organizational and dependency issues #1808

bridiver opened this issue Oct 23, 2018 · 2 comments · Fixed by brave/brave-core#719
Assignees
@bridiver
Labels
feature/rewards QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
0.56.x - Release ...

Comments

@bridiver
Copy link
Contributor

bridiver commented Oct 23, 2018 •
edited by srirambv
Loading

Test plan

See #1808 (comment)

component resources are not well organized or encapsulated within the relevant components. This makes resources both hard to find and also difficult to use in other projects like android
@bridiver bridiver self-assigned this Oct 23, 2018
@bridiver bridiver mentioned this issue Oct 23, 2018
Merged
18 tasks
@NejcZdovc NejcZdovc added this to the 0.55.x - Release Hotfix 2 milestone Oct 24, 2018
bridiver added a commit to brave/brave-core that referenced this issue Oct 24, 2018
@bridiver
fix resource organization and dependencies
3482036 
fix brave/brave-browser#1808
@bridiver
Copy link
Contributor Author

Test plan:

  1. Open Rewards UI - all text should visible without translation placeholders

bridiver added a commit that referenced this issue Oct 24, 2018
@bridiver
Merge pull request #1817 from /issues/1808
4c979e1 
update paths for brave/brave-core#719
bridiver added a commit that referenced this issue Oct 24, 2018
@bridiver
Merge pull request #1817 from /issues/1808
b158520 
update paths for brave/brave-core#719
bridiver added a commit that referenced this issue Oct 25, 2018
@bridiver
Merge pull request #1817 from /issues/1808
c3ea9c7 
update paths for brave/brave-core#719
@LaurenWags
Copy link
Member

LaurenWags commented Nov 1, 2018 •
edited by GeetaSarvadnya
Loading

Verified passed with

Brave 0.56.7 Chromium: 70.0.3538.77 (Official Build) beta(64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Mac OS X

Verification passed on

Brave 0.56.8 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Linux

Verification Passed on

Brave 0.56.8 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bridiver bridiver

Labels
feature/rewards QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.56.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

fix resource organization and dependencies brave/brave-core
6 participants
@bridiver @kjozwiak @NejcZdovc @srirambv @LaurenWags @GeetaSarvadnya