-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eWEEK news page is Speedreader-enabled but probably shouldn't be #18231
Comments
This should have been fixed by #17355 and #18151. I can repro on Linux for release but not 1.32.x. Does it show the icon for https://cnet.com/news also? |
was able to repro on linux too |
|
Just to clean up the blank space on eweek. Landed: easylist/easylist@1bf2a3c |
@stephendonner For the test plan just verify those two sites don't show the icon any longer and this all works as expected. Some things to note:
|
Non-distilled sites can reach OnComplete(), so let's create a more explicit API with a DistillStatus enum to check if distillation was successful. Resolves brave/brave-browser#18231
Description
eWEEK news page is Speedreader-enabled but probably shouldn't be
Steps to Reproduce
https://www.eweek.com/news/
Actual result:
enabled
disabled
Expected result:
Not sure; the page doesn't appear to be a good candidate for Speedreader, though. It looks pretty close, if not identical, to non-Speedreader
Reproduces how often:
100%
Brave version (brave://version info)
/cc @keur
The text was updated successfully, but these errors were encountered: