Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eWEEK news page is Speedreader-enabled but probably shouldn't be #18231

Open
stephendonner opened this issue Sep 20, 2021 · 5 comments
Open

eWEEK news page is Speedreader-enabled but probably shouldn't be #18231

stephendonner opened this issue Sep 20, 2021 · 5 comments
Assignees
Labels
bug feature/speedreader OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains.

Comments

@stephendonner
Copy link

stephendonner commented Sep 20, 2021

Description

eWEEK news page is Speedreader-enabled but probably shouldn't be

Steps to Reproduce

  1. new profile
  2. launch Brave
  3. load https://www.eweek.com/news/
  4. click on the Speedreader icon in the URL bar
  5. after it reloads, look at the resulting page

Actual result:

Speedreader enabled Speedreader disabled
Screen Shot 2021-09-20 at 2 11 43 PM Screen Shot 2021-09-20 at 2 11 48 PM

Expected result:

Not sure; the page doesn't appear to be a good candidate for Speedreader, though. It looks pretty close, if not identical, to non-Speedreader

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.32.4 Chromium: 94.0.4606.50 (Official Build) nightly (x86_64)
Revision 0c1ac2c4842a4746c27c937c1a0453f98da1a972-refs/branch-heads/4606@{#1049}
OS macOS Version 11.6 (Build 20G165)

/cc @keur

@kkuehlz
Copy link
Contributor

kkuehlz commented Sep 20, 2021

This should have been fixed by #17355 and #18151. I can repro on Linux for release but not 1.32.x. Does it show the icon for https://cnet.com/news also?

@kkuehlz kkuehlz self-assigned this Sep 20, 2021
@kkuehlz kkuehlz added priority/P3 The next thing for us to work on. It'll ride the trains. bug OS/macOS OS/Desktop and removed OS/Desktop OS/macOS labels Sep 20, 2021
@kkuehlz
Copy link
Contributor

kkuehlz commented Sep 20, 2021

was able to repro on linux too

@stephendonner
Copy link
Author

stephendonner commented Sep 20, 2021

This should have been fixed by #17355 and #18151. I can repro on Linux for release but not 1.32.x. Does it show the icon for https://cnet.com/news also?

Yup!
Screen Shot 2021-09-20 at 2 32 37 PM

@ryanbr
Copy link

ryanbr commented Sep 21, 2021

Just to clean up the blank space on eweek. Landed: easylist/easylist@1bf2a3c

@kkuehlz
Copy link
Contributor

kkuehlz commented Sep 22, 2021

@stephendonner For the test plan just verify those two sites don't show the icon any longer and this all works as expected. Some things to note:

  1. You will need to hard refresh on those sites that are being incorrectly shown as readable, since the browser cached that incorrect data. Once you do that it should never happen again.
  2. I added some regression tests for the icon. Should help for future rebases.

kkuehlz pushed a commit to brave/brave-core that referenced this issue Sep 22, 2021
Non-distilled sites can reach OnComplete(), so let's create a more
explicit API with a DistillStatus enum to check if distillation was
successful.

Resolves brave/brave-browser#18231
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/speedreader OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants