Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unverified pubs tipping banner message isn't translated to Japanese locale #18374

Closed
GeetaSarvadnya opened this issue Sep 27, 2021 · 2 comments · Fixed by brave/brave-core#10559

Comments

@GeetaSarvadnya
Copy link

Description

Found while testing #18153
Unverified pubs tipping banner message isn't translated to Japanese locale

Steps to Reproduce

  1. Set OS locale to Japanese
  2. Clean profile 1.32.20
  3. Enable rewards and connect KYC'd bitflyer account
  4. Open any unverified pubs (e.g CNN.COM)
  5. Open tipping banner, unverified pubs tipping banner message isn't translated to Japanese

Actual result:

Unverified pubs tipping banner message isn't translated in Japanese

image

Expected result:

message should be translated to Japanese locale

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.32.20 Chromium: 94.0.4606.54 (Official Build) nightly (64 ビット)
変更履歴 c8191a1d5cccbf64e8fe7269043f8ace8d74dd05-refs/branch-heads/4606@{#1130}
OS Windows 10 Version 1809 (Build 17763.1637)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @zenparsing @szilardszaloki

@kjozwiak
Copy link
Member

Closing as brave/brave-core#10559 landed into master and is being uplifted via Updated l10n for 1.31.x release (1.32.x). #10578 - brave/brave-core#10578 & brave/brave-core#10579.

@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Oct 19, 2021

Verification passed on

Brave	1.31.87 Chromium: 95.0.4638.54 (Official Build) (64 ビット)
変更履歴	d31a821ec901f68d0d34ccdbaea45b4c86ce543e-refs/branch-heads/4638@{#871}
OS	Windows 10 Version 1809 (Build 17763.1637)

Verification PASSED on macOS 11.6 x64 using the following build:

Brave | 1.31.87 Chromium: 95.0.4638.54 (Official Build) (x86_64)
--- | ---
Revision | d31a821ec901f68d0d34ccdbaea45b4c86ce543e-refs/branch-heads/4638@{#871}
OS | macOS Version 11.6 (Build 20G165)

スクリーンショット 2021-10-19 10 38 14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants