Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connected publisher message is not shown in the BR panel for DDG #18153

Closed
GeetaSarvadnya opened this issue Sep 16, 2021 · 4 comments · Fixed by brave/brave-core#10181
Closed

Comments

@GeetaSarvadnya
Copy link

Description

Connected publisher message is not shown in the BR panel for DDG

Steps to Reproduce

  1. Clean profile 1.31.41 staging env
  2. Enable rewards, connect KYC'd uphold wallet
  3. Open DDG (or any other connected pubs), click on the panel
  4. Connected pubs message isn't shown in the BR panel

Actual result:

Connected publisher message is not shown in the BR panel for DDG
image

Expected result:

1.29.x

image

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.31.41 Chromium: 94.0.4606.41 (Official Build) nightly (64-bit)
Revision 333e85df3c9b656b518b5f1add5ff246365b6c24-refs/branch-heads/4606@{#845}
OS Windows 10 OS Version 2009 (Build 19043.1165)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @rebron @szilardszaloki

@LaurenWags
Copy link
Member

cc @Miyayes @zenparsing @codybanxs - I am marking this as release/blocking and putting in the 1.31.x milestone for the same reasons we did this for #17941 and #17869. If you disagree please feel free to change.

@LaurenWags
Copy link
Member

labelling QA/Blocked until uplift to 1.31.x is completed

@LaurenWags LaurenWags added QA/Blocked and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Sep 28, 2021
@kjozwiak
Copy link
Member

Removing QA/Blocked as brave/brave-core#10181 was uplifted into 1.31.x via brave/brave-core#10224.

@LaurenWags
Copy link
Member

LaurenWags commented Oct 4, 2021

Verified passed with

Brave | 1.31.70 Chromium: 94.0.4606.71 (Official Build) beta (x86_64)
-- | --
Revision | 1d32b169326531e600d836bd395efc1b53d0f6ef-refs/branch-heads/4606@{#1256}
OS | macOS Version 10.15.7 (Build 19H1417)

See testing notes under #18341 (comment)


Verification passed on


Brave | 1.31.71 Chromium: 94.0.4606.71 (Official Build) beta (64-bit)
-- | --
Revision | 1d32b169326531e600d836bd395efc1b53d0f6ef-refs/branch-heads/4606@{#1256}
OS | Windows 10 Version 21H1 (Build 19043.1237)

Testing notes are available in #17941 (comment)


Verified PASSED using

Brave 1.31.81 Chromium: 95.0.4638.40 (Official Build) beta (64-bit)
Revision e3e7c76ba0284b16087cf4cf3153abfaef6470c7-refs/branch-heads/4638@{#624}
OS Linux

Testing notes available at #18341 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment