Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users to disable Brave custom ad notification fallback from brave://flags #18846

Closed
tmancey opened this issue Oct 18, 2021 · 2 comments · Fixed by brave/brave-core#11093
Closed

Allow users to disable Brave custom ad notification fallback from brave://flags #18846

tmancey opened this issue Oct 18, 2021 · 2 comments · Fixed by brave/brave-core#11093
Assignees
@tmancey
Labels
1_point For Agile sizing enhancement feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA/Yes release-notes/exclude
Milestone
1.34.x - Release

Comments

@tmancey
Copy link
Contributor

tmancey commented Oct 18, 2021

No description provided.

@jsecretan jsecretan added the 1_point For Agile sizing label Oct 19, 2021
@tmancey tmancey removed priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude labels Oct 26, 2021
@tmancey tmancey added QA/Yes release-notes/exclude priority/P3 The next thing for us to work on. It'll ride the trains. labels Nov 15, 2021
@tmancey tmancey mentioned this issue Nov 15, 2021
Merged
24 tasks
@tmancey tmancey self-assigned this Nov 15, 2021
@Jurek54321
Copy link

@tmancey tmancey added this to the 1.34.x - Nightly milestone Nov 16, 2021
@btlechowski btlechowski added QA/In-Progress Indicates that QA is currently in progress for that particular issue and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Dec 16, 2021
@btlechowski
Copy link

btlechowski commented Dec 21, 2021 •
edited
Loading

Verification passed on

Brave 1.34.63 Chromium: 96.0.4664.110 (Official Build) beta (64-bit)
Revision d5ef0e8214bc14c9b5bbf69a1515e431394c62a6-refs/branch-heads/4664@{#1283}
OS Ubuntu 18.04 LTS

It seems that the flag has no effect. Per our process I logged a follow up issue #20218

@btlechowski btlechowski mentioned this issue Dec 24, 2021
Closed
@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
1_point For Agile sizing enhancement feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA/Yes release-notes/exclude
Projects
Ads
Archived in project
Milestone
1.34.x - Release
Development

Successfully merging a pull request may close this issue.

Allow users to disable Brave custom ad notification fallback from brave://flags brave/brave-core
4 participants
@jsecretan @tmancey @btlechowski @Jurek54321