Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to disable Brave custom ad notification fallback from brave://flags #11093

Merged
merged 1 commit into from
Nov 16, 2021

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Nov 15, 2021

Resolves brave/brave-browser#18846

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Confirm user can override the can_fallback_to_custotm_notifications Griffin field trial flag to disallow falling back to custom ad notifications by disabling Allowed to fallback to custom push notification ads in brave://flags or by disabling the AllowedToFallbackToCustomAdNotifications Griffin feature. Default value for AllowedToFallbackToCustomAdNotifications is Enabled.

Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmancey tmancey force-pushed the issues/18846 branch 3 times, most recently from baf3be5 to a921f32 Compare November 16, 2021 15:32
@tmancey tmancey merged commit b9870bb into master Nov 16, 2021
@tmancey tmancey deleted the issues/18846 branch November 16, 2021 20:57
@tmancey tmancey added this to the 1.34.x - Nightly milestone Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow users to disable Brave custom ad notification fallback from brave://flags
2 participants