Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling WDP via Tor disables WDP in Normal windows #18958

Closed
kjozwiak opened this issue Oct 22, 2021 · 3 comments
Closed

Disabling WDP via Tor disables WDP in Normal windows #18958

kjozwiak opened this issue Oct 22, 2021 · 3 comments

Comments

@kjozwiak
Copy link
Member

Description

When you have WDP enabled via brave://settings/search in Normal windows, launching Tor will disable the setting. This is a follow up to #18885.

Steps to Reproduce

  1. launch Brave via a clean profile
  2. enable WDP via brave://search/settings and ensure that WDP.IsRunning --> true
  3. launch a Tor window
  4. you'll notice that WDP has been disabled via brave://settings/search
  5. close the Tor window and the WDP setting will still be disabled

Actual result:

The WDP setting is being reset to disabled via Normal windows when a Tor window is a launched

Expected result:

WDP should be disabled for Tor windows but it shouldn't affect the state of Normal windows.

Reproduces how often:

100% reproducible using the above STR.

Brave version (brave://version info)

Brave | 1.33.30 Chromium: 95.0.4638.54 (Official Build) nightly (64-bit)
-- | --
Revision | d31a821ec901f68d0d34ccdbaea45b4c86ce543e-refs/branch-heads/4638@{#871}
OS | Windows 11 Version 21H2 (Build 22000.258)

Version/Channel Information:

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

CCing @remusao @rebron @diracdeltas

@remusao
Copy link

remusao commented Oct 25, 2021

Resolved by brave/brave-core#10670

@kjozwiak
Copy link
Member Author

STR/Cases can be used from brave/brave-core#10670 (comment).

@stephendonner
Copy link

stephendonner commented Oct 29, 2021

Verified PASSED using

Brave 1.31.88 Chromium: 95.0.4638.69 (Official Build) (x86_64)
Revision 6a1600ed572fedecd573b6c2b90a22fe6392a410-refs/branch-heads/4638@{#984}
OS macOS Version 11.6.1 (Build 20G224)

Steps:

  1. launched Brave via a clean profile
  2. enabled WDP via brave://search/settings and ensure that WDP.IsRunning --> true via brave://inspect#extensions -> console
  3. launched a Private Window with Tor
  4. closed the Tor window

Confirmed once set, the Web Discovery Project toggle remained On

example example example
Screen Shot 2021-10-29 at 4 58 22 AM Screen Shot 2021-10-29 at 4 59 02 AM Screen Shot 2021-10-29 at 4 59 17 AM

See also additional, thorough verification in #18885 (comment).


Verification passed on

Brave | 1.31.88 Chromium: 95.0.4638.69 (Official Build) (64-bit)
-- | --
Revision | 6a1600ed572fedecd573b6c2b90a22fe6392a410-refs/branch-heads/4638@{#984}
OS | Windows 10 Version 21H1 (Build 19043.1288)

Steps:

  1. launched Brave via a clean profile
  2. enabled WDP via brave://settings/search and ensure that WDP.isRunning --> true via brave://inspect#extensions -> console
  3. launched a Private Window with Tor
  4. closed the Tor window

Confirmed once set, the Web Discovery Project toggle remained On

example example example
image image image

Verification passed on

Brave 1.31.88 Chromium: 95.0.4638.69 (Official Build) (64-bit)
Revision d31a821ec901f68d0d34ccdbaea45b4c86ce543e-refs/branch-heads/4638@{#871}
OS Ubuntu 18.04 LTS
image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment