Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Web Discovery Project in Tor windows #10609

Merged
merged 1 commit into from
Oct 20, 2021
Merged

Conversation

remusao
Copy link
Collaborator

@remusao remusao commented Oct 20, 2021

Resolves brave/brave-browser#18885

Currently the Web Discovery Project is active in Tor windows (if user opted-in). This is unintended and we do not want WDP running in Tor windows even after opt-in.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@remusao remusao force-pushed the wdp-disabled-on-tor branch from 6904641 to 15a6cda Compare October 20, 2021 14:28
@kjozwiak
Copy link
Member

Tested and created brave/brave-browser#18958 👍 Will re-check once brave/brave-browser#18958 is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure WDP is completely disabled on Tor windows
3 participants