Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build failure on macOS CI - AttributeError: module 'plistlib' has no attribute 'readPlist' #18965

Closed
simonhong opened this issue Oct 25, 2021 · 0 comments · Fixed by brave/brave-core#10667
Closed

Build failure on macOS CI - AttributeError: module 'plistlib' has no attribute 'readPlist' #18965

simonhong opened this issue Oct 25, 2021 · 0 comments · Fixed by brave/brave-core#10667
Assignees
@simonhong
Labels
dev-concern OS/Desktop QA/No release-notes/exclude
Milestone
1.31.x - Release #2

Comments

@simonhong
Copy link
Member 

00:04:45  [17501/53424] ACTION //brave:brave_app_plist(//build/toolchain/mac:clang_x64)
00:04:45 
 FAILED: gen/brave/brave_app_plist_tweaked.plist 
00:04:45  python3 ../../brave/build/mac/tweak_info_plist.py --brave_channel=nightly --****uct_dir_name=BraveSoftware/Brave-Browser-Nightly --brave_version=1.33.29 --brave_eddsa_key=**** --skip_signing --plist gen/chrome/chrome_app_plist_tweaked.plist --output gen/brave/brave_app_plist_tweaked.plist
00:04:45  Traceback (most recent call last):
00:04:45    File "/Users/jenkins/jenkins/workspace/test-brave-browser-build-macos-x64-nightly/src/out/Release/../../brave/build/mac/tweak_info_plist.py", line 121, in <module>
00:04:45      sys.exit(Main())
00:04:45    File "/Users/jenkins/jenkins/workspace/test-brave-browser-build-macos-x64-nightly/src/out/Release/../../brave/build/mac/tweak_info_plist.py", line 88, in Main
00:04:45      plist = plistlib.readPlist(temp_info_plist.name)
00:04:45 
 AttributeError: module 'plistlib' has no attribute 'readPlist'
@simonhong simonhong self-assigned this Oct 25, 2021
@simonhong simonhong mentioned this issue Oct 25, 2021
Merged
24 tasks
simonhong added a commit to brave/brave-core that referenced this issue Oct 25, 2021
@simonhong
Handled deprecated readPlist/writePlist in tweak_info_plist.py
cb4f8c4 
fix brave/brave-browser#18965

Use load/dump for python3 instead.
@simonhong simonhong added this to the 1.33.x - Nightly milestone Oct 25, 2021
@brave-builds brave-builds mentioned this issue Oct 25, 2021
Merged
7 tasks
@mkarolin mkarolin mentioned this issue Oct 25, 2021
Merged
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
dev-concern OS/Desktop QA/No release-notes/exclude
Projects
None yet
Milestone
1.31.x - Release #2
Development

Successfully merging a pull request may close this issue.

Handled deprecated readPlist/writePlist in tweak_info_plist.py brave/brave-core
2 participants
@kjozwiak @simonhong