Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable P3A uploads on Android #19302

Closed
bsclifton opened this issue Nov 9, 2021 · 1 comment · Fixed by brave/brave-core#11030 or brave/brave-core#11063
Closed

Re-enable P3A uploads on Android #19302

bsclifton opened this issue Nov 9, 2021 · 1 comment · Fixed by brave/brave-core#11030 or brave/brave-core#11063
Assignees
@bsclifton
Labels
features/P3A OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.32.x - Release #2

Comments

@bsclifton
Copy link
Member

Description

P3A uploading temporarily disabled with brave/brave-core#10940

(see #19280)

We should re-enable this once we understand the root cause or if we determine this didn't impact things over the weekend
@bsclifton bsclifton added the OS/Android Fixes related to Android browser functionality label Nov 9, 2021
@bsclifton bsclifton mentioned this issue Nov 9, 2021
Closed
iefremov added a commit to brave/brave-core that referenced this issue Nov 11, 2021
@iefremov
Avoid DST problems in P3A uploads schedule.
ba7f118 
The day when clock go backwards is "longer" than 24 hours in terms
of local timezone. This caused a perfect storm in p3a uploads,
making the rotation timer inifinitely shoot with 0 delay. Here
we transit to a WallClockTimer for better accuracy and also
avoid the timezone change problem.

Fixes brave/brave-browser#19302
Partially fixes brave/brave-browser#19125
@iefremov iefremov mentioned this issue Nov 11, 2021
Merged
24 tasks
bsclifton added a commit to brave/brave-core that referenced this issue Nov 12, 2021
@bsclifton
Revert "Merge pull request #10940 from brave/bsc-disable-p3a-android"
f22ba07 
Fixes brave/brave-browser#19302

This reverts commit b562e68, reversing
changes made to fa87a4b.
@bsclifton bsclifton mentioned this issue Nov 13, 2021
Merged
24 tasks
@bsclifton bsclifton added this to the 1.34.x - Nightly milestone Nov 15, 2021
This was referenced Nov 19, 2021
Merged
Merged
iefremov added a commit to brave/brave-core that referenced this issue Nov 19, 2021
@iefremov
Avoid DST problems in P3A uploads schedule.
2c3bbda 
The day when clock go backwards is "longer" than 24 hours in terms
of local timezone. This caused a perfect storm in p3a uploads,
making the rotation timer inifinitely shoot with 0 delay. Here
we transit to a WallClockTimer for better accuracy and also
avoid the timezone change problem.

Fixes brave/brave-browser#19302
Partially fixes brave/brave-browser#19125
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 23, 2021 •
edited by kjozwiak
Loading

Verification passed on Vivo X70 Pro version Android 11 running Bravemonoarm.64_apk_1.32.111

Case 1: Clean install
  • Downloaded/installed1.32.111 and left P3A enabled via on-boarding
  • Double checked that P3A was enabled via Hamburger Menu -> Settings -> Brave shields & privacy
  • Open a few websites and add bookmarks and change the default search engine and enable rewards
  • Ensured that the changes were being captured using P3A via brave://local-state
  • Ensure that some of the data is eventually sent by making sure that "sent:" true as P3A enabled
Case 2: Upgrade install
  • Downloaded/installed 1.32.106 and left P3A enabled via on-boarding
  • Double checked that P3A was enabled via Hamburger Menu -> Settings -> Brave shields & privacy
  • Open a few websites and add bookmarks and change the default search engine and enable rewards
  • Ensured that the above changes weren't logged via P3A under brave://local-state
  • Upgraded profile to 1.32.111
  • Ensured P3A is still enabled via Hamburger Menu -> Settings -> Brave shields & privacy
  • Should easily be able to tell that P3A is working/logging changes under brave://local-state by taking a look at the P3A section

Verification PASSED on Samsung Galaxy Tab A (2019) running Android 11 using the following build:

1.32.112 Chromium: 96.0.4664.45

Test Case #1 (Clean Install):

  • downloaded/installed1.32.112 Chromium: 96.0.4664.45 and left P3A enabled via on-boarding
  • double checked that P3A was enabled via Hamburger Menu -> Settings -> Brave shields & privacy
  • opened several tabs & changed the default search engine via Settings
  • ensured that the changes were being captured using P3A via brave://local-state

Test Case #1 (Upgrading):

  • downloaded/installed 1.32.106 Chromium: 96.0.4664.45 and left P3A enabled via on-boarding
  • double checked that P3A was enabled via Hamburger Menu -> Settings -> Brave shields & privacy
  • opened several tabs & changed the default search engine via Settings
  • ensured that the above changes weren't logged via P3A under brave://local-state
  • upgraded from 1.32.112 Chromium: 96.0.4664.45
  • should easily be able to tell that P3A is working/logging changes under brave://local-state by taking a look at P3A section

@kjozwiak kjozwiak mentioned this issue Nov 24, 2021
Closed
rillian pushed a commit to brave/brave-core that referenced this issue Dec 6, 2021
@iefremov @rillian
Avoid DST problems in P3A uploads schedule.
6ff070f 
The day when clock go backwards is "longer" than 24 hours in terms
of local timezone. This caused a perfect storm in p3a uploads,
making the rotation timer inifinitely shoot with 0 delay. Here
we transit to a WallClockTimer for better accuracy and also
avoid the timezone change problem.

Fixes brave/brave-browser#19302
Partially fixes brave/brave-browser#19125
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bsclifton bsclifton

Labels
features/P3A OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
None yet
Milestone
1.32.x - Release #2
6 participants
@rillian @kjozwiak @bsclifton @anthonypkeane @SergeyZhukovsky @GeetaSarvadnya