Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IPFS dialog for page info version 2 #19421

Closed
rebron opened this issue Nov 12, 2021 · 4 comments
Closed

Update IPFS dialog for page info version 2 #19421

rebron opened this issue Nov 12, 2021 · 4 comments
Assignees
Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/web3/ipfs OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include

Comments

@rebron
Copy link
Collaborator

rebron commented Nov 12, 2021

Description

Update design for ipfs dialog to support page info version 2 currently viewable brave://flags/#page-info-version-2-desktop in 1.31.x but will be on by default in 1.34.x and Chromium 97.

Current result:

pagebubblev1vsv2

Expected result:

[Design placeholder]

Reproduces how often:

Enable flag. brave://flags/#page-info-version-2-desktop
Visit IPFS page e.g. ipfs://bafybeiemxf5abjwjbikoz4mc3a3dla6ual3jsgpdr4cjr3oz3evfyavhwq/wiki/Vincent_van_Gogh.html
Select IPFS icon in the url bar and open page info dialog.

Brave version (brave://version info)

1.31.x and higher with flag enabled.

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes w/ flag enabled
  • Can you reproduce this issue with the beta channel? yes w/ flag enabled
  • Can you reproduce this issue with the nightly channel? yes w/ flag enabled

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

Follow-up to #16907

@rebron rebron added design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. priority/P3 The next thing for us to work on. It'll ride the trains. OS/Desktop labels Nov 12, 2021
@rebron rebron self-assigned this Nov 12, 2021
@spylogsster
Copy link

spylogsster commented Nov 19, 2021

temporarily fixed it as brave/brave-core#11167 in cr98 and cr97 branch

@stephendonner
Copy link

Verified PASSED using

Brave 1.37.18 Chromium: 98.0.4758.87 (Official Build) nightly (x86_64)
Revision e4cd00f135fb4d8edc64c8aa6ecbe7cc79ebb3b2-refs/branch-heads/4758@{#1002}
OS macOS Version 11.6.1 (Build 20G224)

IPFS scheme

example example example example
Screen Shot 2022-02-01 at 4 45 32 PM Screen Shot 2022-02-01 at 4 45 34 PM Screen Shot 2022-02-01 at 4 41 36 PM Screen Shot 2022-02-01 at 4 41 42 PM

HTTPS scheme

example example example example
Screen Shot 2022-02-01 at 4 47 29 PM Screen Shot 2022-02-01 at 4 47 31 PM Screen Shot 2022-02-01 at 4 44 49 PM Screen Shot 2022-02-01 at 4 44 52 PM

@MadhaviSeelam
Copy link

MadhaviSeelam commented Mar 3, 2022

Verified PASSED using

Brave 1.37.80 Chromium: 99.0.4844.51 (Official Build) beta (64-bit)
Revision d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875}
OS Windows 11 Version 21H2 (Build 22000.493)
  • Visit IPFS page with
    • ipfs://bafybeiemxf5abjwjbikoz4mc3a3dla6ual3jsgpdr4cjr3oz3evfyavhwq/wiki/Vincent_van_Gogh.html
    • ipns://ipfs.io/
  • Select IPFS icon in the url bar and open page info dialog.
  • Verified HTTPs pages as well.
  • Verified No flag is available brave://flags/#page-info-version-2-desktop in brave://flags

IPFS scheme - Dark and Light modes

1 2 3 4
Screenshot 2022-03-03 123743 Screenshot 2022-03-03 123847 Screenshot 2022-03-03 150531 Screenshot 2022-03-03 150617

HTTPS scheme - - Dark and Light modes

1 2 3 4
Screenshot 2022-03-03 123923 Screenshot 2022-03-03 123959 Screenshot 2022-03-03 150342 Screenshot 2022-03-03 150132

@stephendonner
Copy link

Adding QA-Pass-Win64; thanks for verifying on Windows, @MadhaviSeelam !

@rebron rebron changed the title update IPFS dialog for page info version 2 Update IPFS dialog for page info version 2 Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/web3/ipfs OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Development

No branches or pull requests

4 participants