Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPFS protocol badge should link to settings and node diagnostics #16907

Closed
lidel opened this issue Jul 12, 2021 · 1 comment · Fixed by brave/brave-core#9899
Closed

IPFS protocol badge should link to settings and node diagnostics #16907

lidel opened this issue Jul 12, 2021 · 1 comment · Fixed by brave/brave-core#9899

Comments

@lidel
Copy link

lidel commented Jul 12, 2021

Current UI only has "Learn more" which links to https://support.brave.com/hc/en-us/sections/360010974932-InterPlanetary-File-System-IPFS- which is ok but bit dry:

UI in Nightly 1.28.28:

2021-07-12--20-54-53

To make onboarding and customization easier, I believe we should add more to this popup (could be 3 links under "Learn more", or buttons similar to "Cookies" – whatever makes more sense:

  1. "IPFS Settings" – link to brave://settings/ipfs
  2. "IPFS Diagnostics – brave://ipfs-internals/
  3. "IPFS Docs" → https://docs.ipfs.io/
@stephendonner
Copy link

Verified PASSED using

Brave 1.31.10 Chromium: 93.0.4577.58 (Official Build) nightly (x86_64)
Revision c4410ece044414ea42fa4ba328d08195e818a99c-refs/branch-heads/4577@{#1076}
OS macOS Version 11.5.2 (Build 20G95)

Steps:

  1. new profile
  2. launch Brave
  3. load ipns://en.wikipedia-on-ipfs.org
  4. click on Use a local node
  5. click on Open using IPFS
  6. now click on the IPFS badge icon in the URL bar
  7. confirm the presence and destination of the links

Confirmed:

  • IPFS docs - links to https://docs.ipfs.io/
  • IPFS diagnostics - links to brave://ipfs-internals/
  • IPFS settings - links to brave://settings/ipfs

Screen Shot 2021-08-31 at 8 35 06 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants