Rework pending contributions processor to handle cross-provider tips

[zenparsing]

Description

Follow-up to #19996.

Cross-provider pending tips (where the user is connected to an external rewards wallet provider A and wants to tip a creator that is only connected through provider B) are currently disabled. As we work toward reenabling this feature we should refactor the pending contribution processor for maintainability.

[LaurenWags]

Added OS/Android as Android will be getting the "Pending Contributions" view as of 1.38.x, so this will affect them as well.

With 1.38.x on Android tips to "Unverified" creators go to the pending list, but tips in the cross custodian case (Uphold wallet tipping a Gemini creator) or connected case (Uphold wallet attempting to tip a creator who is "Connected" - that is, creator is Brave verified but does not have a custodial wallet connected in creators) do not go to Pending list.

cc @Miyayes

[GeetaSarvadnya]

Verification is in-progress

Brave | 1.41.74 Chromium: 103.0.5060.53 (Official Build) beta (64-bit)
-- | --
Revision | a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853}
OS | Windows 10 Version 21H2 (Build 19044.1766)

• Verified the test plan from Fix pending tips processing for verified Rewards profiles brave-core#13609
• Confirmed one-time tip is processed for laurenwags.github.io
• Confirmed that one tip is shown in the Tips panel
• Confirmed one-time tip is shown in the rewards summary and monthly statement and brave://rewrads-internals pages
• Confirmed that 1 BAT is deducted from uphold and the same is reflected in the transaction history

Step 3	Step 4	Step 5	Step 6	Step 7	Step 8	Step 10 (a)	Step 10 (b)	Step 12	Step 13 (a)	Step 13 (b)	Step 13 (c)	Step 13 (d)	Step 14

[stephendonner]

Verified PASSED using

Brave	1.41.86 Chromium: 103.0.5060.66 (Official Build) beta (x86_64)
Revision	20b1569438a85e631d15e83eb355e3e326e5da6f-refs/branch-heads/5060@{#1066}
OS	macOS Version 11.6.7 (Build 20G630)

Steps

1. installed 1.41.86
2. launched Brave using --args --enable-logging=stderr --vmodule="*/bat-native-ledger/*"=9,"*/brave_rewards/*"=9,"*/bat-native-ads/*"=9,"*/bat-native-confirmations/*"=9,"*/brave_ads/*"=9,"*/brave_user_model/*"=9 --rewards=staging=true,debug=true
3. clicked on the BAT icon
4. clicked on Start using Rewards
5. opened brave://rewards/
6. clicked on Unverified
7. verified with my Uphold account
8. loaded https://github.com/miyayes
9. clicked on the BAT icon
10. made a one-time tip of 1 BAT
11. loaded brave://rewards and viewed the list of pending tips
12. confirmed tip was pending
13. opened the panel on https://github.com/miyayes and clicked the Refresh status button
14. loaded brave://rewards and viewed the list of pending tips
15. verified that the one-time tip created above appears in the list of pending tips, and no other tips appear
16. shut down Brave
17. opened publisher_info_db from the top level Default directory of my user profile (pending_contributions table)
18. changed publisher_id to laurenwags.github.io
19. launched Brave
20. loaded laurenwags.github.io
21. opened the Rewards panel
22. clicked on the Refresh button
23. confirmed pending tip went through via Uphold via their ledger & locally on brave://rewards-internals

example	example	example	example	example	example	example	example	example	example	example	example

[stephendonner]

Verified PASSED using

Steps

1. installed 1.41.86
2. launched Brave using --args --enable-logging=stderr --vmodule="*/bat-native-ledger/*"=9,"*/brave_rewards/*"=9,"*/bat-native-ads/*"=9,"*/bat-native-confirmations/*"=9,"*/brave_ads/*"=9,"*/brave_user_model/*"=9 --rewards=staging=true,debug=true
3. clicked on the BAT icon
4. clicked on Start using Rewards
5. opened brave://rewards/
6. clicked on Unverified
7. verified with my Uphold account
8. loaded https://github.com/miyayes
9. clicked on the BAT icon
10. made a one-time tip of 1 BAT
11. loaded brave://rewards and viewed the list of pending tips
12. confirmed tip was pending
13. opened the panel on https://github.com/miyayes and clicked the Refresh status button
14. loaded brave://rewards and viewed the list of pending tips
15. verified that the one-time tip created above appears in the list of pending tips, and no other tips appear
16. shut down Brave
17. opened publisher_info_db from the top level Default directory of my user profile (pending_contributions table)
18. changed publisher_id to laurenwags.github.io
19. launched Brave
20. loaded laurenwags.github.io
21. opened the Rewards panel
22. clicked on the Refresh button
23. confirmed pending tip went through via Uphold via their ledger & locally on brave://rewards-internals

example	example	example	example	example	example	example	example	example	example	example	example

[srirambv]

Verification passed on Oppo Reno 5 with Android 12 running 1.41.96 x64 build

• Verified steps from brave/brave-core#13609
• Verified one-time tip is processed for laurenwags.github.io
• Verified that one tip is shown in the Tips panel
• Verified one-time tip is shown in the rewards summary and monthly statement and brave://rewrads-internals pages
• Verified that 1 BAT is deducted from uphold and the same is reflected in the transaction history
• Encountered #24006