Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filtered_categories is cleared and blocked ad is shown #20482

Closed
btlechowski opened this issue Jan 12, 2022 · 4 comments · Fixed by brave/brave-core#11906
Closed

filtered_categories is cleared and blocked ad is shown #20482

btlechowski opened this issue Jan 12, 2022 · 4 comments · Fixed by brave/brave-core#11906

Comments

@btlechowski
Copy link

btlechowski commented Jan 12, 2022

Follow up to #20206

When we attempt to serve the 2nd notification ad, the filtered_categories is cleared and the previously filtered ad is shown
This is a regression in 1.36.x. Not reproducible in 1.34.x

Steps to Reproduce

  1. Clear profile
  2. Enable ads
  3. Create a catalog with one untargeted ad
  4. Show an untargeted ad
  5. Block the ad in the brave://rewards
  6. Close Brave
  7. Wait 1h
  8. Run Brave
  9. Show an untargeted ad

Actual result:

filtered_categories in ads_service/client.json is cleared
Ad is shown

Expected result:

Ad is blocked:

[25255:25255:0113/063155.873920:VERBOSE1:eligible_ad_notifications_v1.cc(39)] Get eligible ad notifications:
[25255:25255:0113/063155.874810:VERBOSE1:eligible_ad_notifications_v1.cc(140)] Get eligible ads for untargeted segment
[25255:25255:0113/063155.875697:VERBOSE2:exclusion_rules_base.cc(123)] creativeSetId 5f8c4787-8431-49a5-9d09-bba40f8ad5f4 excluded due to being marked to no longer receive ads

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.36.29 Chromium: 97.0.4692.71 (Official Build) nightly (64-bit)
Revision adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS Ubuntu 18.04 LTS

cc @tmancey @jsecretan @rebron @brave/legacy_qa

@btlechowski
Copy link
Author

The same can be observed for dislike .
The filtered_advertisers is cleared and the 2nd ad is shown.

@tmancey tmancey self-assigned this Jan 13, 2022
@tmancey tmancey added priority/P3 The next thing for us to work on. It'll ride the trains. release/blocking labels Jan 13, 2022
@tmancey
Copy link
Contributor

tmancey commented Jan 19, 2022

@btlechowski you do not need to wait 1 hour, you just need to relaunch the browser to reproduce instead of waiting

@tmancey tmancey added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Jan 19, 2022
@tmancey tmancey added this to the 1.36.x - Nightly milestone Jan 19, 2022
@btlechowski
Copy link
Author

Requires build higher than 1.35.92.

@btlechowski
Copy link
Author

Verification passed on

Brave 1.35.93 Chromium: 97.0.4692.99 (Official Build) beta (64-bit)
Revision d740da257583289dbebd2eb37e8668928fac5ead-refs/branch-heads/4692@{#1461}
OS Ubuntu 18.04 LTS

Verified test plan from #20482 (comment)

Blocked

Marked Blocked
image

Verified is blocked in client.json
image

Verified still blocked after 1h and browser restart
image
image

Verified ads from the blocked category are actually blocked

[17600:17600:0127/021129.085376:VERBOSE2:exclusion_rules_base.cc(123)] creativeSetId c49b78ab-27a3-4a08-9cda-434f097d8cf8 excluded due to being marked to no longer receive ads
[17600:17600:0127/021129.085459:VERBOSE2:exclusion_rules_base.cc(123)] creativeSetId 2003f580-4703-408a-aab4-881230aa4a6c excluded due to being marked to no longer receive ads
[17600:17600:0127/021129.085521:VERBOSE2:exclusion_rules_base.cc(123)] creativeSetId 5e96fecc-2926-4c72-bb76-4e745bf6b539 excluded due to being marked to no longer receive ads

Dislike

Marked as disliked
image

Verified is blocked in client.json
image

Verified still blocked after 1h and browser restart
image
image

Verified ads from the blocked advertiser are actually blocked

[18783:18783:0127/032438.592368:VERBOSE2:exclusion_rules_base.cc(123)] advertiserId ecbcc833-8b1d-4867-98f7-ad2341396ce8 excluded due to being disliked

@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants