Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up of PR #11931 - Payment arrived message is not shown #20671

Closed
GeetaSarvadnya opened this issue Jan 25, 2022 · 2 comments
Closed

Follow up of PR #11931 - Payment arrived message is not shown #20671

GeetaSarvadnya opened this issue Jan 25, 2022 · 2 comments

Comments

@GeetaSarvadnya
Copy link

Description

Follow up of PR brave/brave-core#11931 - Payment arrived message is not shown

Steps to Reproduce

  1. Follow the STR from Arrived message is not showing up the actual claimed BAT amount #20597
  2. Payment arrived message is not shown

Actual result:

Payment arrived message is not shown

Expected result:

Payment arrived message should be shown

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.36.60 Chromium: 97.0.4692.99 (Official Build) nightly (64-bit)
Revision d740da257583289dbebd2eb37e8668928fac5ead-refs/branch-heads/4692@{#1461}
OS Windows 10 Version 21H2 (Build 19044.1466)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? NA
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @Miyayes @brave/legacy_qa @LaurenWags @zenparsing

@GeetaSarvadnya GeetaSarvadnya changed the title Follow up of PR https://github.com/brave/brave-core/pull/11931 - Payment arrived message is not shown Follow up of PR #11931 - Payment arrived message is not shown Jan 25, 2022
@GeetaSarvadnya
Copy link
Author

The issue is fixed and working fine, verification note are linked in brave/brave-core#11931 (comment)

@kjozwiak
Copy link
Member

As per discussion with @LaurenWags, going to move this into 1.35.x even though it wasn't fixed by any PRs. Labelling it as QA/No so no one else runs through it accidently. @GeetaSarvadnya already confirmed it's working as per #20671 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment