Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next payment date is empty on brave://rewards #20715

Closed
stephendonner opened this issue Jan 26, 2022 · 5 comments · Fixed by brave/brave-core#12027
Closed

Next payment date is empty on brave://rewards #20715

stephendonner opened this issue Jan 26, 2022 · 5 comments · Fixed by brave/brave-core#12027

Comments

@stephendonner
Copy link

Description

Next payment date is empty on brave://rewards

Steps to Reproduce

Pre-requisite: set your system clock to New York, New York or another UTC-5 timezone

  1. install 1.36.x or 1.35.x
  2. launch Brave
  3. click on Skip welcome tour
  4. load brave://rewards
  5. click on Start using Brave Rewards
  6. click on the X on the dialog's top right
  7. note the Next payment date

Actual result:

blank-payment-date

Expected result:

Next payment date should have a date value

expected

NOTE: a refresh fixes it

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.36.70 Chromium: 98.0.4758.66 (Official Build) nightly (64-bit)
Revision db1b4001d5ce29f141297f260d2b778e000b85a3-refs/branch-heads/4758@{#762}
OS Windows 10 Version 20H2 (Build 19042.1466)

Version/Channel Information:

  • Can you reproduce this issue with the current release? no
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

cc @LaurenWags @btlechowski @emerick @zenparsing

@LaurenWags
Copy link
Member

cc @tmancey too

@stephendonner
Copy link
Author

stephendonner commented Jan 26, 2022

This works when you, instead, do the following:

  1. install 1.36.x or 1.35.x
  2. launch Brave using production envs.
  3. click on Skip welcome tour
  4. click on Start using Brave Rewards on the new-tab page widget
  5. now load brave://rewards
  6. note the Next payment date is fine: 5th

@LaurenWags
Copy link
Member

very similar to #11107, which was closed with closed/wontfix label. not sure if this is the same. cc @Miyayes

@tmancey
Copy link
Contributor

tmancey commented Jan 27, 2022

@LaurenWags this is a different issue as 1.35.x and above no longer wait for a response from the server. I will investigate soon. However, as this would only happen on a fresh install and after a page refresh fixes itself, I would say we do not need to uplift. Thanks. cc @jsecretan

@tmancey tmancey self-assigned this Jan 27, 2022
@tmancey tmancey added priority/P3 The next thing for us to work on. It'll ride the trains. release-notes/exclude and removed rewards-2.0 labels Jan 27, 2022
@tmancey tmancey added this to the 1.37.x - Nightly milestone Jan 28, 2022
@stephendonner
Copy link
Author

stephendonner commented Feb 1, 2022

Verified PASSED using

Brave 1.37.13 Chromium: 98.0.4758.74 (Official Build) nightly (64-bit)
Revision d0fe1ec4df090cd3eb02b591228505e12ea476e9-refs/branch-heads/4758@{#935}
OS Windows 10 Version 20H2 (Build 19042.1466)

Followed my original steps to reproduce, and confirmed the Next payment date is correctly populated.

20715-1


Verified PASSED using

Brave 1.37.23 Chromium: 98.0.4758.87 (Official Build) nightly (x86_64)
Revision e4cd00f135fb4d8edc64c8aa6ecbe7cc79ebb3b2-refs/branch-heads/4758@{#1002}
OS macOS Version 11.6.1 (Build 20G224)

Followed my original steps to reproduce, and confirmed the Next payment date is correctly populated.

example example example
Screen Shot 2022-02-03 at 5 53 56 PM Screen Shot 2022-02-03 at 5 59 26 PM Screen Shot 2022-02-03 at 6 00 03 PM

Verification passed on

Brave 1.37.83 Chromium: 99.0.4844.51 (Official Build) beta (64-bit)
Revision d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875}
OS Ubuntu 18.04 LTS

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment