Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page refresh is causing the Browser Crash #762

Closed
GeetaSarvadnya opened this issue Aug 17, 2018 · 8 comments · Fixed by brave/brave-core#378 or brave/brave-core#628
Closed

Page refresh is causing the Browser Crash #762

GeetaSarvadnya opened this issue Aug 17, 2018 · 8 comments · Fixed by brave/brave-core#378 or brave/brave-core#628
Assignees
@bbondy
Labels
crash QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Milestone
0.55.x - Release ...

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Aug 17, 2018 •
edited
Loading

Description

Page refresh is causing the Browser Crash

Steps to Reproduce

  1. Launch brave with clean profile
  2. Click on Skip Welcome tour link
  3. Click on Brave web store
  4. Click on Last Pass extension, observer the pop up and close it
  5. Click on Hoeny extension
  6. Click on Refresh icon twice observe Honey pop up refreshed twice
  7. Click on Browser back button twice and observer Last Pass extension pop up
  8. Click on Refresh icon ( sometimes crash happens on 1st refresh, sometimes on 2nd crash)
  9. Observe the browser crash

Actual result:

Page refresh is causing the Browser Crash
page refresh causes browser crash

Crash ID:
Uploaded Crash Report ID ed8d5514e59baea0 (Local Crash ID: 90642fdd-f635-4668-b236-5923fbd435d9)
Crash report captured on Friday, August 17, 2018 at 9:52:11 PM, uploaded on Friday, August 17, 2018 at 9:54:06 PM

Expected result:

Browser should not crash

Reproduces how often:

Easily

Brave version (about:brave info)

Version 0.54.0 Chromium: 69.0.3497.32 (Official Build) dev (64-bit)

Reproducible on current release:

No

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? - No
  • Is the issue reproducible on the latest version of Chrome? - No

Additional Information

cc: @bbondy
@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Aug 25, 2018 •
edited
Loading

Re-validated the issue against the new build 0.54.1. Brave crashes on step 6 after first refresh.
Please find the crash id below:
Crash Report ID 6a447afd1ef04754
cc: @bbondy

@GeetaSarvadnya
Copy link
Author

@bbondy : Brave crashes on step 6 after first refresh.
Please find the crash id - Crash Report ID ac318e853176edf6

@bbondy bbondy mentioned this issue Aug 31, 2018
Merged
11 tasks
bbondy added a commit to brave/brave-core that referenced this issue Aug 31, 2018
@bbondy
Use a single sequenced task runner for HTTPSEverywehre
0532a57 
Otherwise we're creating lots of different threads and accessing things for the DB on different possibly overlapping threads

I think this also fixes:
brave/brave-browser#707
brave/brave-browser#708
brave/brave-browser#739
brave/brave-browser#797
brave/brave-browser#761
brave/brave-browser#762
brave/brave-browser#796
brave/brave-browser#797
brave/brave-browser#798
brave/brave-browser#861
@srirambv
Copy link
Contributor

srirambv commented Sep 4, 2018

Still reproduced on 0.54.4 Crash ID: 6d10f81f0fad0396

@srirambv srirambv reopened this Sep 4, 2018
@GeetaSarvadnya
Copy link
Author

Issue is fixed and working fine on 0.55.1. Hence closing the issue

@bbondy bbondy added the QA/Yes label Sep 10, 2018
@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Sep 21, 2018 •
edited by LaurenWags
Loading

Verification PASS on:

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows

Verification Passed on

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux
Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Mac OS X

@bbondy bbondy added the QA/Yes label Sep 27, 2018
@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Oct 13, 2018 •
edited
Loading

Issue is reproducible on 0.55.13. Hence reopening the issue.
Crash ID: d07a89e24b8b8c66
https://stats.brave.com/dashboard#crash/5bc218916a0e96001e2792b2
brave crashes on 0 55 13_reload chrome web store page

bbondy added a commit to brave/brave-core that referenced this issue Oct 14, 2018
@bbondy
Fix crash on empty URL adblock / TP checks
74bde58 
Fix brave/brave-browser#762
@bbondy bbondy mentioned this issue Oct 14, 2018
Merged
18 tasks
@kjozwiak
Copy link
Member

Clearing the QA Pass flags as this needs to be retested.

@srirambv
Copy link
Contributor

srirambv commented Oct 16, 2018 •
edited by GeetaSarvadnya
Loading

Verification Passed on

Brave 0.55.14 Chromium: 70.0.3538.54 (Official Build) beta(64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Linux
  • Verified the steps from issue and no crash

Verified passed with

Brave 0.55.14 Chromium: 70.0.3538.54 (Official Build) beta(64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Mac OS X
  • Verified with STR from description

Verification Passed on

Brave 0.55.16 Chromium: 70.0.3538.54 (Official Build) (64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Windows
  • Verified with STR from description

@LaurenWags LaurenWags mentioned this issue May 24, 2019
Closed
@stephendonner stephendonner mentioned this issue Jan 22, 2022
Closed
22 tasks
@btlechowski btlechowski mentioned this issue Jan 24, 2022
Closed
22 tasks
This was referenced Jan 25, 2022
Closed
Closed
Closed
@btlechowski btlechowski mentioned this issue Jan 27, 2022
Closed
This was referenced Jan 27, 2022
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbondy bbondy

Labels
crash QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
5 participants
@bbondy @kjozwiak @srirambv @LaurenWags @GeetaSarvadnya