Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching network doesn't update the default value #21136

Closed
srirambv opened this issue Feb 16, 2022 · 1 comment · Fixed by brave/brave-core#12487
Closed

Switching network doesn't update the default value #21136

srirambv opened this issue Feb 16, 2022 · 1 comment · Fixed by brave/brave-core#12487
Assignees
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include

Comments

@srirambv
Copy link
Contributor

Description

Switching network doesn't update the default value

Steps to reproduce

  1. Add a custom network
  2. Open Send screen
  3. Set network to Mainnet, ETH is the default token listed
  4. Enter a default % value or manually enter it
  5. Select network drop down and select the custom network
  6. Input value and default asset doesn't reset
  7. Able to submit a transaction with wrong token but transaction confirmation screen shows the correct token name

Actual result

Network.Change.on.Send.Android.MP4

Expected result

Similar to desktop

Change.Network.mp4

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes when 1.36.x is released
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): All
  • Android version: All

Brave version

1.36.x

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @SergeyZhukovsky @wchen342

@srirambv srirambv added bug QA/Yes release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Feb 16, 2022
@bbondy bbondy added the priority/P2 A bad problem. We might uplift this to the next planned release. label Feb 25, 2022
@wchen342 wchen342 self-assigned this Mar 3, 2022
@wchen342 wchen342 added this to the 1.38.x - Nightly milestone Mar 7, 2022
@bbondy bbondy added this to Web3 Mar 18, 2022
@bbondy bbondy moved this to Done in Web3 Mar 18, 2022
@srirambv
Copy link
Contributor Author

Verification passed on the following devices running 1.38.107 x64 build

  • Verified steps from issue description
  • Verified changing network on send screen resets the input value
  • Logged #22572 as a follow up to update the token as well
Oppo Reno 5 (Android 12) Samsung Tab A (Android 10)
21136-ARM.mp4
21136-Tab.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants