Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to native token when network is changed on Send/Swap screen #22572

Closed
srirambv opened this issue Apr 27, 2022 · 9 comments · Fixed by brave/brave-core#14085
Closed

Update to native token when network is changed on Send/Swap screen #22572

srirambv opened this issue Apr 27, 2022 · 9 comments · Fixed by brave/brave-core#14085
Assignees
Labels
bug enhancement feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include

Comments

@srirambv
Copy link
Contributor

Description

Update to native token when network is changed on Send/Swap screen

Steps to reproduce

  1. Install 1.38.107
  2. Select Send tokens on Ethereum Mainnet
  3. Select a preset value or manually enter
  4. Select a different network say Polygon from the network dropdown
  5. Because of brave/brave-core#12487, only input value is reset but the token still remains ETH instead of changing over to MATIC

Actual result

Native.Token.not.set.mp4

Expected result

Should switch to native token when network is changed and not just reset the input values

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): All
  • Android version: All

Brave version

1.38.107

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @Pavneet-Sing @wchen342

@srirambv srirambv added enhancement QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Apr 27, 2022
@srirambv srirambv added this to Web3 Apr 27, 2022
@jamesmudgett jamesmudgett added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jun 7, 2022
@jamesmudgett jamesmudgett moved this to Backlog in Web3 Jun 7, 2022
@deeppandya
Copy link

@srirambv will verify and close if all okay.

@srirambv
Copy link
Contributor Author

This is still an issue on current master (1.42.43)

@wchen342
Copy link

Haven't got a change to fix it yet, will get on it soon.

@Pavneet-Sing
Copy link

[Info]: This needs to be fixed on android Dapps panel.

https://community.brave.com/t/android-brave-crashes-when-adding-a-network-in-brave-wallet/408504

@aman-m1
Copy link

aman-m1 commented Jun 30, 2022

Also, would it be possible to show, may be through a toggle, the wallet extension icon all the time if user wanted to? And not just on a Dapp.

@Pavneet-Sing
Copy link

@aman-m1 Thanks for the suggestion. We hide the icon due to security concerns though will pass on your suggestion.

@jamesmudgett
Copy link

@aman-m1 yes we can add something

@Pavneet-Sing
Copy link

This implementation on Panel is still pending on panel #22572 (comment), since this has been closed so created a new issue to fix it on panel.
#24078

@srirambv
Copy link
Contributor Author

Verification passed on the following devices running 1.43.74 x64 Beta build

  • Verified steps from issue description
  • Verified changing network resets the input value and updates the token to network's native token
Oppo Reno 5(Android 12) Samsung Tab A (Android 10)
22572-ARM.mp4
22572-Tab.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug enhancement feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants