-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to native token when network is changed on Send/Swap screen #22572
Comments
@srirambv will verify and close if all okay. |
This is still an issue on current master (1.42.43) |
Haven't got a change to fix it yet, will get on it soon. |
[Info]: This needs to be fixed on android Dapps panel. https://community.brave.com/t/android-brave-crashes-when-adding-a-network-in-brave-wallet/408504 |
Also, would it be possible to show, may be through a toggle, the wallet extension icon all the time if user wanted to? And not just on a Dapp. |
@aman-m1 Thanks for the suggestion. We hide the icon due to security concerns though will pass on your suggestion. |
@aman-m1 yes we can add something |
This implementation on Panel is still pending on panel #22572 (comment), since this has been closed so created a new issue to fix it on panel. |
Verification passed on the following devices running 1.43.74 x64 Beta build
|
Description
Update to native token when network is changed on Send/Swap screen
Steps to reproduce
ETH
instead of changing over toMATIC
Actual result
Native.Token.not.set.mp4
Expected result
Should switch to native token when network is changed and not just reset the input values
Issue reproduces how often
Easy
Version/Channel Information:
Device details
Brave version
1.38.107
Website problems only
Additional information
cc: @Pavneet-Sing @wchen342
The text was updated successfully, but these errors were encountered: