Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync strings should match text in original spec #2122

Closed
cezaraugusto opened this issue Nov 13, 2018 · 1 comment · Fixed by brave/brave-core#901
Closed

sync strings should match text in original spec #2122

cezaraugusto opened this issue Nov 13, 2018 · 1 comment · Fixed by brave/brave-core#901
Assignees
@cezaraugusto
Labels
about-pages/sync QA/No release-notes/exclude
Milestone
0.57.x - Release ...

Comments

@cezaraugusto
Copy link
Contributor

see brave/brave-ui@32444f2#diff-0dbf27e6e01de3d93b465fa7203d7783 which sets the current spec. both works should be paired with the same text.

by now setting as the last milestone which is 0.59.x. should be changed if sync hits mainstream before that.
@cezaraugusto cezaraugusto added this to the 0.59.x - Nightly milestone Nov 13, 2018
@cezaraugusto cezaraugusto self-assigned this Nov 13, 2018
@cezaraugusto cezaraugusto mentioned this issue Nov 13, 2018
Merged
@cezaraugusto
Copy link
Contributor Author

changed to 0.57.x to reflect the landing of sync

@kjozwiak kjozwiak mentioned this issue Jan 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cezaraugusto cezaraugusto

Labels
about-pages/sync QA/No release-notes/exclude
Projects
None yet
Milestone
0.57.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

update sync locale strings brave/brave-core
2 participants
@cezaraugusto @rebron