Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update sync locale strings #901

Merged
merged 1 commit into from
Nov 15, 2018
Merged

update sync locale strings #901

merged 1 commit into from
Nov 15, 2018
+9 −9

Conversation

cezaraugusto
Copy link
Contributor

@cezaraugusto cezaraugusto self-assigned this Nov 13, 2018
rossmoody
rossmoody approved these changes Nov 13, 2018
View reviewed changes
Copy link
Contributor

@rossmoody rossmoody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for posterity, these were iterative changes reacting only to what is here but I think there are more significant changes coming down the pipeline for this.

@cezaraugusto cezaraugusto merged commit 246c75d into master Nov 15, 2018
@cezaraugusto cezaraugusto deleted the sync-strings branch November 15, 2018 17:47
cezaraugusto added a commit that referenced this pull request Nov 15, 2018
@cezaraugusto
Merge pull request #901 from brave/sync-strings
4b59038 
update sync locale strings
cezaraugusto added a commit that referenced this pull request Nov 15, 2018
@cezaraugusto
Merge pull request #901 from brave/sync-strings
261bba6 
update sync locale strings
@cezaraugusto
Copy link
Contributor Author

heads-up I'm adding this to 0.57.x directly since Sync is scheduled for that release cc @srirambv @kjozwiak

master (0.59.x) 246c75d
0.58.x 4b59038
0.57.x 261bba6

@kjozwiak
Copy link
Member

@cezaraugusto thanks for the heads up. CCing @rebron.

@bbondy bbondy added this to the 0.57.x - Release milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossmoody rossmoody rossmoody approved these changes

Assignees

@cezaraugusto cezaraugusto

Labels
None yet
Projects
None yet
Milestone
0.57.x - Release
Development

Successfully merging this pull request may close these issues.

sync strings should match text in original spec
5 participants
@cezaraugusto @kjozwiak @rossmoody @bbondy @NejcZdovc