Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove microsoft-edge protocol handler #21553

Closed
bsclifton opened this issue Mar 9, 2022 · 5 comments · Fixed by brave/brave-core#12556
Closed

Remove microsoft-edge protocol handler #21553

bsclifton opened this issue Mar 9, 2022 · 5 comments · Fixed by brave/brave-core#12556
Assignees
@simonhong
Labels
OS/Desktop OS/Windows QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.37.x - Release

Comments

@bsclifton
Copy link
Member

Description

Originally captured with #13875 and #17558, we had added a way to set the microsoft-edge handler
image

This was patched by Microsoft in Windows 11 breaking the feature and it eventually this patch made its way to Windows 10 also. If you try to open a search after setting it, you're presented with Microsoft Edge only options
image

We can likely remove this code completely (added in brave/brave-core#9778 and brave/brave-core#10879)
@bsclifton bsclifton changed the title Remove Remove microsoft-edge protocol handler Mar 9, 2022
@stephendonner
Copy link

stephendonner commented Mar 9, 2022 •
edited
Loading

+1000; I personally see this all the time (like @kjozwiak ) so will most-happily help verify its removal.

simonhong added a commit to brave/brave-core that referenced this issue Mar 10, 2022
@simonhong
Delete ms-edge protocol handling
61ff443 
fix brave/brave-browser#21553

Deleted all ms-edge protocol handling logic as Windows doesn't allow
3p applications as a default ms-edge protocol handler.
@simonhong simonhong mentioned this issue Mar 10, 2022
Merged
25 tasks
simonhong added a commit to brave/brave-core that referenced this issue Mar 11, 2022
@simonhong
Delete ms-edge protocol handling
ed69d85 
fix brave/brave-browser#21553

Deleted all ms-edge protocol handling logic as Windows doesn't allow
3p applications as a default ms-edge protocol handler.
@simonhong simonhong added this to the 1.38.x - Nightly milestone Mar 11, 2022
@kjozwiak
Copy link
Member

@bsclifton @rebron something we want to get uplifted into 1.37.x?

@bsclifton
Copy link
Member Author

bsclifton commented Mar 14, 2022 •
edited
Loading

@kjozwiak we definitely can- let me create one and share

edit: here ya go 😄
brave/brave-core#12590

@brave-builds brave-builds mentioned this issue Mar 14, 2022
Merged
7 tasks
muliswilliam pushed a commit to brave/brave-core that referenced this issue Mar 16, 2022
@simonhong @muliswilliam
Delete ms-edge protocol handling
e0e33a2 
fix brave/brave-browser#21553

Deleted all ms-edge protocol handling logic as Windows doesn't allow
3p applications as a default ms-edge protocol handler.
@kjozwiak
Copy link
Member

Will require 1.37.100 or higher for 1.37.x verifications.

@GeetaSarvadnya
Copy link

Verification PASSED on


Brave | 1.37.106 Chromium: 100.0.4896.46 (Official Build) (64-bit)
-- | --
Revision | 5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS | Windows 10 Version 21H2 (Build 19044.1586)
  • Confirmed ms-edge protocol handling is removed from the brave://settings/system
1.36.119 1.37.106
image image

@kjozwiak kjozwiak mentioned this issue Mar 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
OS/Desktop OS/Windows QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.37.x - Release
Development

Successfully merging a pull request may close this issue.

Delete ms-edge protocol handling brave/brave-core
5 participants
@stephendonner @kjozwiak @bsclifton @simonhong @GeetaSarvadnya