Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State-level ad targeting string needs renaming in brave://settings/rewards #22001

Closed
stephendonner opened this issue Mar 30, 2022 · 3 comments · Fixed by brave/brave-core#12847

Comments

@stephendonner
Copy link

Description

State-level ad targeting string needs renaming in brave://settings/rewards

Steps to Reproduce

  1. install 1.39.18
  2. launch Brave
  3. open brave://rewards/
  4. opt-in to Rewards
  5. click on the Settings icon for Brave Private Ads
  6. look at the term used there: Regional ad relevance
  7. open brave://settings/rewards
  8. look at the term used there: State-level ad targeting

This was renamed over in #21291 for brave://rewards, but missed for Settings.

Actual result:

brave://settings/rewards brave://rewards
Screen Shot 2022-03-30 at 3 25 58 PM Screen Shot 2022-03-30 at 3 26 03 PM

Expected result:

It should read Regional ad relevance everywhere.

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.39.18 Chromium: 100.0.4896.60 (Official Build) nightly (x86_64)
Revision 6a5d10861ce8de5fce22564658033b43cb7de047-refs/branch-heads/4896@{#875}
OS macOS Version 11.6.5 (Build 20G527)

cc @tmancey @Tonev

@Tonev
Copy link
Contributor

Tonev commented Mar 31, 2022

@stephendonner @tmancey 👋

👇
brave/brave-core#12847

@GeetaSarvadnya
Copy link

Reproduced in Windows 10 x64 - 1.38.75

@stephendonner
Copy link
Author

Verified PASSED using

Brave 1.39.39 Chromium: 100.0.4896.79 (Official Build) nightly (x86_64)
Revision 8fb749dcab8700c24213791969e59deb72fee36f-refs/branch-heads/4896@{#1015}
OS macOS Version 11.6.5 (Build 20G527)

Confirmed the string in brave://settings/rewards now reads Regional ad relevance.

Screen Shot 2022-04-07 at 1 14 11 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants