Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed State-level ad targeting at brave://settings/rewards #12847

Merged
merged 2 commits into from
Apr 4, 2022

Conversation

Tonev
Copy link
Contributor

@Tonev Tonev commented Mar 31, 2022

This changes State-level ad targeting to Regional ad relevance at brave://settings/rewards

Resolves brave/brave-browser#22001

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

This changes State-level ad targeting to Regional ad relevance at brave://settings/rewards
@Tonev Tonev changed the title Changed state-level ad targeting string Changed State-level ad targeting at brave://settings/rewards Mar 31, 2022
@stephendonner stephendonner requested review from tmancey and aseren March 31, 2022 18:01
@tmancey tmancey self-requested a review March 31, 2022 18:49
Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-)

@Tonev
Copy link
Contributor Author

Tonev commented Apr 1, 2022

Thank you for your review, @tmancey! Please, merge whenever you think it is appropriate because I don't have required access to do it myself. Of course, if @aseren doesn't find anything that has to be fixed 👍

Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmancey tmancey merged commit 64a08e2 into brave:master Apr 4, 2022
@tmancey tmancey added this to the 1.39.x - Nightly milestone Apr 4, 2022
@Tonev Tonev deleted the issues22001 branch April 9, 2022 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

State-level ad targeting string needs renaming in brave://settings/rewards
2 participants