Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash on BraveFederatedService Unwanted Start #22037

Closed
LorenzoMinto opened this issue Apr 1, 2022 · 6 comments · Fixed by brave/brave-core#12858
Closed

Crash on BraveFederatedService Unwanted Start #22037

LorenzoMinto opened this issue Apr 1, 2022 · 6 comments · Fixed by brave/brave-core#12858
Assignees
@LorenzoMinto
Labels
crash OS/Android Fixes related to Android browser functionality OS/Desktop private-federated-learning Private Federated Learning QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Device-Types QA/Test-All-Platforms QA/Yes release-notes/include
Milestone
1.37.x - Release #2

Comments

@LorenzoMinto
Copy link
Member

LorenzoMinto commented Apr 1, 2022 •
edited by kjozwiak
Loading

Description

Steps to Reproduce

As per @LorenzoMinto via Slack, QA basically needs to ensure that enabling/disabling P3A via Settings doesn't cause any crashes.

Actual result:

Expected result:

Reproduces how often:

Desktop Brave version:

Android Device details:

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:
@LorenzoMinto LorenzoMinto added OS/Android Fixes related to Android browser functionality OS/Desktop labels Apr 1, 2022
@LorenzoMinto LorenzoMinto mentioned this issue Apr 1, 2022
Merged
25 tasks
@yrliou yrliou added this to the 1.39.x - Nightly milestone Apr 1, 2022
This was referenced Apr 1, 2022
Merged
Merged
@kjozwiak
Copy link
Member

kjozwiak commented Apr 1, 2022

Adding release-notes/include as this affected users once 1.37.109 Chromium 100.0.4896.60 was released even though it was only 1%.

@kjozwiak
Copy link
Member

kjozwiak commented Apr 1, 2022

Quick note: Couldn't reproduce a crash using 1.37.109 Chromium 100.0.4896.60 as we got the reports from the GPS Dashboard but both @LorenzoMinto & @rillian mentioned that it's reproducible for some people on Linux by simply enabling/disabling P3A. So QA ensured that enabling/disabling P3A didn't cause any other issues/crashes with the above fix.

Verification PASSED on Pixel 6 using Android 12 running 1.37.110 Chromium 100.0.4896.60

  • ensured that enabling/disabling P3A via onboarding didn't cause any crashes/issues
  • ensured that having P3A enabled via onboarding (default) didn't cause any crashes/issues while running through the remaining parts of onboarding
    ensured that having P3A disabled via onboarding didn't cause any crashes/issues while running through the remaining parts of onboarding
  • ensured that enabling/disabling P3A via Brave Shields & privacy didn't cause any issues/crashes

@kjozwiak
Copy link
Member

kjozwiak commented Apr 1, 2022

Removed the QA Pass label as it looks like @Uni-verse might have found a crash with onboarding. Investigating if related.

@Uni-verse
Copy link
Contributor

Verified PASSED using 1.37.110, chromium 100.0.4896.60 on Samsung Galaxy Tab S7 running Android 12

  • Verified enabling/disabling P3A in onboarding flow
  • Verified enabling/disabling P3A via privacy settings
  • User is able to complete onboarding flow after enabling/disabling P3A.

@kjozwiak
Copy link
Member

kjozwiak commented Apr 2, 2022

Removed the QA Pass label as it looks like @Uni-verse might have found a crash with onboarding. Investigating if related.

What @Uni-verse found was already in 1.36.x and not new to 1.37.x. We'll create a new issue/keep an eye on it. @Uni-verse mind mentioning the issue once you create a bug report?

@kjozwiak kjozwiak mentioned this issue Apr 2, 2022
Closed
@Uni-verse
Copy link
Contributor

Uni-verse commented Apr 4, 2022 •
edited
Loading

Removed the QA Pass label as it looks like @Uni-verse might have found a crash with onboarding. Investigating if related.

What @Uni-verse found was already in 1.36.x and not new to 1.37.x. We'll create a new issue/keep an eye on it. @Uni-verse mind mentioning the issue once you create a bug report?

#22078

@kjozwiak kjozwiak mentioned this issue Apr 8, 2022
Closed
avinassh pushed a commit to avinassh/brave-browser-hardening that referenced this issue May 29, 2022
Brave Browser 1.37.112 for Android
56025a9 
 - Fixed crash when enabling or disabling P3A in certain cases. ([#22037](brave/brave-browser#22037))
 - Upgraded Chromium to 100.0.4896.79. ([#22077](brave/brave-browser#22077)) ([Changelog for 100.0.4896.79](https://chromium.googlesource.com/chromium/src/+log/100.0.4896.60..100.0.4896.79?pretty=fuller&n=1000))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LorenzoMinto LorenzoMinto

Labels
crash OS/Android Fixes related to Android browser functionality OS/Desktop private-federated-learning Private Federated Learning QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Device-Types QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Milestone
1.37.x - Release #2
Development

Successfully merging a pull request may close this issue.

Gate service creation on BuildServiceInstanceFor brave/brave-core
5 participants
@moritzhaller @kjozwiak @yrliou @LorenzoMinto @Uni-verse