Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use selected network when resolving UD/ENS domains to eth address #22151

Closed
yrliou opened this issue Apr 7, 2022 · 3 comments · Fixed by brave/brave-core#13202
Closed

Do not use selected network when resolving UD/ENS domains to eth address #22151

yrliou opened this issue Apr 7, 2022 · 3 comments · Fixed by brave/brave-core#13202
Assignees
@supermassive
Labels
feature/web3/unstoppable-domains Label for unstoppable domains feature feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.40.x - Release

Comments

@yrliou
Copy link
Member

yrliou commented Apr 7, 2022 •
edited
Loading

Currently we are using selected network when resolving UD/ENS domains to eth address in brave wallet, which doesn't make much sense.
For UD, we should always call unstoppable domains' contracts on ethereum mainnet (and polygon once we have L2 support).
For ENS, we should always call the contracts on ethereum mainnet.
And we should allow the resolution on all EVM network instead of just a few networks, for example, we only allow UD on mainnet and rinkeby at the moment.
@yrliou yrliou added feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop feature/web3/unstoppable-domains Label for unstoppable domains feature feature/web3/wallet/core labels Apr 7, 2022
@supermassive supermassive mentioned this issue May 10, 2022
Merged
25 tasks
@supermassive
Copy link

UD part is fixed here brave/brave-core#13085
ENS part is fixed here brave/brave-core#13202

@supermassive supermassive added this to the 1.40.x - Nightly milestone May 16, 2022
@srirambv
Copy link
Contributor

Verified as part of #22147 (comment)

@srirambv
Copy link
Contributor

Android verification done as part of #22147 (comment)

This was referenced Jun 21, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@supermassive supermassive

Labels
feature/web3/unstoppable-domains Label for unstoppable domains feature feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.40.x - Release
Development

Successfully merging a pull request may close this issue.

Polygon for DNS resolution brave/brave-core
3 participants
@supermassive @yrliou @srirambv