Polygon network for UD wallet address #13085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
CI/storybook-url
supermassive
force-pushed
the
UnstoppabeDomainsPolygon
branch
from
5259f8e
to
562f854
Compare
|
A Storybook has been deployed to preview UI for the latest push |
supermassive
force-pushed
the
UnstoppabeDomainsPolygon
branch
from
562f854
to
f5c5290
Compare
|
A Storybook has been deployed to preview UI for the latest push |
supermassive
force-pushed
the
UnstoppabeDomainsPolygon
branch
from
f5c5290
to
49df1e1
Compare
|
A Storybook has been deployed to preview UI for the latest push |
supermassive
commented
Apr 21, 2022
| @@ -907,6 +909,13 @@ std::string GetDefaultBaseCryptocurrency(PrefService* prefs) { | |||
| return prefs->GetString(kDefaultBaseCryptocurrency); | |||
| } | |||
|
|
|||
| GURL GetUnstoppableDomainsRpcUrl(const std::string& chain_id) { | |||
| if (chain_id == brave_wallet::mojom::kPolygonMainnetChainId) | |||
| return GURL("https://polygon-rpc.com"); | |||
There was a problem hiding this comment.
will be changed to brave.com subdomain in nearest future
| return; | ||
| } | ||
|
|
||
| std::move(callback).Run(address, mojom::ProviderError::kSuccess, ""); | ||
| if (address->empty()) { | ||
| ud_get_eth_addr_calls_->SetNoResult(domain, chain_id); |
There was a problem hiding this comment.
Empty result is not an error. Now handled by frontend
| @@ -1762,44 +1765,203 @@ TEST_F(JsonRpcServiceUnitTest, UnstoppableDomainsProxyReaderGetMany) { | |||
| EXPECT_TRUE(callback_called); | |||
| } | |||
|
|
|||
| TEST_F(JsonRpcServiceUnitTest, UnstoppableDomainsGetEthAddr) { | |||
| // Non-support chain (localhost) should fail. | |||
There was a problem hiding this comment.
Removed that test block. Now always use eth mainnet and polygon mainnet
supermassive
changed the title
yrliou
reviewed
Apr 22, 2022
components/brave_wallet/browser/unstoppable_domains_multichain_calls.h
Outdated
Show resolved
Hide resolved
supermassive
force-pushed
the
UnstoppabeDomainsPolygon
branch
from
9a27348
to
d867100
Compare
|
A Storybook has been deployed to preview UI for the latest push |
yrliou
approved these changes
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#22146
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: