Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amount you entered for asset in Swap will keep changing market price and result in error #22308

Closed
Uni-verse opened this issue Apr 14, 2022 · 2 comments · Fixed by brave/brave-core#13023
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes regression release-notes/include

Comments

@Uni-verse
Copy link
Contributor

Description

When entering an amount for an asset on the swap screen, it will proceed to count the value and then display an error

Steps to reproduce

  1. Using quick action, select Swap
  2. Enter an amount for the assets

Actual result

The amount changes

device-2022-04-14-131103.mp4

Expected result

The amount you entered should remain

Issue reproduces how often

Easily

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version?
  • Can you reproduce this issue with the current Play Store Beta version?
  • Can you reproduce this issue with the current Play Store Nightly version?

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Samsung Galaxy S21
  • Android version: 12

Brave version

1.38.93, Chromium 100.0.4896.88

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@Uni-verse Uni-verse added bug priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes regression feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Apr 14, 2022
@Uni-verse Uni-verse added this to the 1.38.x - Beta milestone Apr 14, 2022
@Uni-verse Uni-verse changed the title Amount you entered for asset in Swap will keep changing in field and result in error Amount you entered for asset in Swap will keep changing market price and result in error Apr 14, 2022
@SergeyZhukovsky SergeyZhukovsky moved this to Done in Web3 Apr 14, 2022
@kjozwiak
Copy link
Member

Above requires 1.38.99 or higher for 1.38.x verification.

@srirambv
Copy link
Contributor

Verification passed on Oppo Reno 5 with Android 12 running 1.38.108 x64 build

  • Verified steps from issue description
  • Verified Swap value doesn't auto-update constantly
  • Verified with multiple Swap To tokens

Verification passed on Samsung Tab A with Android 10 running 1.38.108 x64 build

  • Verified steps from issue description
  • Verified Swap value doesn't auto-update constantly
  • Verified with multiple Swap To tokens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes regression release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants