Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes an endless Market price field update on Android Swap #13023

Merged
merged 1 commit into from
Apr 14, 2022

Conversation

SergeyZhukovsky
Copy link
Member

Resolves brave/brave-browser#22308

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@SergeyZhukovsky SergeyZhukovsky added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Apr 14, 2022
@SergeyZhukovsky SergeyZhukovsky self-assigned this Apr 14, 2022
Copy link

@Pavneet-Sing Pavneet-Sing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@SergeyZhukovsky SergeyZhukovsky added this to the 1.39.x - Nightly milestone Apr 14, 2022
@SergeyZhukovsky SergeyZhukovsky merged commit 0623ecb into master Apr 14, 2022
@SergeyZhukovsky SergeyZhukovsky deleted the android_swap_update branch April 14, 2022 20:28
brave-builds pushed a commit that referenced this pull request Apr 14, 2022
@Uni-verse
Copy link
Contributor

Verified on Nightly 1.39.61, Chromium 100.0.4896.88

Devices:
Samsung Galaxy S21 | Android 12
Samsung Galaxy Tab S7 | Android 12

  • Market Price in Eth does not change when amount is entered for the asset in swap
22308_fix.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Amount you entered for asset in Swap will keep changing market price and result in error
3 participants