Android and Desktop must use same code for sync QR code generation

[AlexeyBarabash]

Currently Desktop uses QRCodeGeneratorService and Android uses com.google.zxing.MultiFormatWriter and fills the bitmap.

Need to use the same code. Also the style of the QR code image might bi aligned with "Share page through QR style" - have rounded dots and the Brave's logo.

[iccub]

iOS counterpart brave/brave-ios#5391

[stephendonner]

Verification PASSED using

Brave	1.40.80 Chromium: 102.0.5005.78 (Official Build) beta (x86_64)
Revision	df6dbb5a9fd82af3f567198af2eb5fb4876ef99c-refs/branch-heads/5005_59@{#3}
OS	macOS Version 11.6.6 (Build 20G624)

Setup/steps:

Steps (chain creator):

1. install 1.40.80
2. launch Brave
3. click on the "Hamburger" menu on the main toolbar
4. click on Sync
5. click on Start using Sync
6. click on Start a new Sync Chain
7. click on Computer
8. click on View QR Code
9. click on OK
10. click on Manage Sync Devices and wait for the clients to roll in and appear, as you test

Steps (joining client):

1. install 1.40.80
2. launch Brave
3. click on the "Hamburger" menu on the main toolbar
4. click on Sync
5. click on Start using Sync
6. click on I have a Sync Code
7. confirm you can successfully join the sync chain, and are listed accordingly

Results

* Confirmed I was able to set up a Sync chain via brave://settings/braveSync/setup

* Confirmed I was able to join the above Sync chain via either code words (desktop) or QR code (Android & iOS)

Sync-chain creator	desktop client	Android client	iOS client	brave://settings/braveSync/setup
desktop

---

Verification PASSED on

Brave | 1.40.83 Chromium: 102.0.5005.78 (Official Build) beta (64-bit)
-- | --
Revision | df6dbb5a9fd82af3f567198af2eb5fb4876ef99c-refs/branch-heads/5005_59@{#3}
OS | Windows 10 Version 21H2 (Build 19044.1706)

• Logged Unable to copy code words from existing sync chain #23262

Steps (chain creator):

1. install 1.40.80
2. launch Brave
3. click on the "Hamburger" menu on the main toolbar
4. click on Sync
5. click on Start using Sync
6. click on Start a new Sync Chain
7. click on Computer
8. click on View QR Code
9. click on OK
10. click on Manage Sync Devices and wait for the clients to roll in and appear, as you test

Steps (joining client):

1. install 1.40.80
2. launch Brave
3. click on the "Hamburger" menu on the main toolbar
4. click on Sync
5. click on Start using Sync
6. click on I have a Sync Code
7. confirm you can successfully join the sync chain, and are listed accordingly

Results

* Confirmed I was able to set up a Sync chain via brave://settings/braveSync/setup

* Confirmed I was able to join the above Sync chain via either code words (desktop) or QR code (Android & iOS)

Sync-chain creator	desktop client	Android client	iOS client	brave://settings/braveSync/setup
Desktop

---

Verification passed on

Brave	1.40.87 Chromium: 102.0.5005.78  (Official Build) (64-bit)
Revision	df6dbb5a9fd82af3f567198af2eb5fb4876ef99c-refs/branch-heads/5005_59@{#3}
OS	Ubuntu 18.04 LTS

Setup/steps:

Steps (chain creator):

1. install 1.40.x
2. launch Brave
3. click on the "Hamburger" menu on the main toolbar
4. click on Sync
5. click on Start using Sync
6. click on Start a new Sync Chain
7. click on Computer
8. click on View QR Code
9. click on OK
10. click on Manage Sync Devices and wait for the clients to roll in and appear, as you test

Steps (joining client):

1. install 1.40.x
2. launch Brave
3. click on the "Hamburger" menu on the main toolbar
4. click on Sync
5. click on Start using Sync
6. click on I have a Sync Code
7. confirm you can successfully join the sync chain, and are listed accordingly

Results

* Confirmed I was able to set up a Sync chain via brave://settings/braveSync/setup

* Confirmed I was able to join the above Sync chain via either code words (desktop) or QR code (Android)

[Uni-verse]

Verification PASSED on Samsung Galaxy S21 & Tab S7 using

Brave	1.40.91 Chromium: 102.0.5005.78 (Official Build) beta (64-bit) 
Revision	df6dbb5a9fd82af3f567198af2eb5fb4876ef99c-refs/branch-heads/5005_59@{#3}
OS	Android 12; Build/SP1A.210812.016

Creating Chain

• Confirmed user is able to start a new sync chain on device.
• Confirmed QR Code contains the brave logo and rounded dots.

Joining Chain

• Confirmed able to join sync chain by scanning QR code that contains brave logo and rounded dots.
• After joining sync chain, Add New Device will display QR code with brave logo and rounded dots.
• Able to join sync chain created on desktop by scanning.
• Able to add other mobile devices to sync chain by scanning generated QR code.

Share link in context menu

• Confirmed QR code has the brave logo and rounded dots.
• Confirmed able to scan QR code generated on mobile device and successfully open link.
• Confirmed able to scan QR code generated on desktop and successfully open link.

Devices on Sync Chain	Scanned to join	Created Chain	QR Code - Mobile Share link	Desktop QR Share link