-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monthly Contribution Dropdown in Wallet Panel should retain value #2245
Closed
ryanml opened this issue
Nov 27, 2018
· 3 comments
· Fixed by brave/brave-core#957 or brave/brave-core#2069
Closed
Monthly Contribution Dropdown in Wallet Panel should retain value #2245
ryanml opened this issue
Nov 27, 2018
· 3 comments
· Fixed by brave/brave-core#957 or brave/brave-core#2069
Labels
feature/rewards
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
release-notes/exclude
Milestone
Comments
17 tasks
Hope we can land this before |
Reverted due to failing unit tests, re-opening. |
17 tasks
18 tasks
NejcZdovc
added
the
priority/P3
The next thing for us to work on. It'll ride the trains.
label
Dec 6, 2018
NejcZdovc
pushed a commit
to ryanml/brave-core
that referenced
this issue
Mar 25, 2019
Fixes brave/brave-browser#2823 Monthly donation functionality via panel
18 tasks
ryanml
added a commit
to brave/brave-core
that referenced
this issue
Mar 28, 2019
Fixes brave/brave-browser#2823 Monthly donation functionality via panel
ryanml
added a commit
to brave/brave-core
that referenced
this issue
Apr 2, 2019
Fixes brave/brave-browser#2823 Monthly donation functionality via panel
NejcZdovc
pushed a commit
to brave/brave-core
that referenced
this issue
Apr 8, 2019
Fixes brave/brave-browser#2823 Monthly donation functionality via panel
pilgrim-brave
pushed a commit
to brave/brave-core
that referenced
this issue
Apr 16, 2019
Fixes brave/brave-browser#2823 Monthly donation functionality via panel
This was referenced May 10, 2019
Verification passed on
Verification passed on
Verified passed with
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature/rewards
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
release-notes/exclude
This should call the functions
SaveRecurringDonation
andRemoveRecurring
. The former should called when a non-0 value is set, and the latter when 0 is set.Description
Steps to Reproduce
brave.com
Actual result:
New value is not returned, is 0.0
Expected result:
Dropdown should be 5.0
Reproduces how often:
Brave version (brave://version info)
Reproducible on current release:
Website problems only:
Additional Information
The text was updated successfully, but these errors were encountered: