Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View on block explorer always opens mainnet link #22534

Closed
srirambv opened this issue Apr 25, 2022 · 2 comments
Closed

View on block explorer always opens mainnet link #22534

srirambv opened this issue Apr 25, 2022 · 2 comments

Comments

@srirambv
Copy link
Contributor

Description

View on block explorer always opens mainnet link

Steps to Reproduce

  1. Perform a transaction on Ropsten
  2. Select token and go to transactions
  3. Click on 3 dot menu and select View on block explorer
  4. Opens up https://etherscan.io/tx/<TXHASH> rather than https://ropsten.etherscan.io/tx/<TXHASH>

Actual result:

Incorrect.Block.Explorer.mov

Expected result:

Should default to network specific block explorer as in current release version

Correct.Block.Explorer.mov

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.38.106 Chromium: 101.0.4951.41 (Official Build) (64-bit)
Revision 93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904}
OS All

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @muliswilliam

@kjozwiak
Copy link
Member

Closing as brave/brave-core#13181 was merged into 1.38.x.

Repository owner moved this from In Progress to Done in Web3 Apr 27, 2022
@srirambv
Copy link
Contributor Author

Brave 1.38.106 Chromium: 101.0.4951.41 (Official Build)
Revision 93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904}
OS ☑️ Linux (Rinkeby) ☑️ Windows 11 Version 22H2
(Build 22598.200) (Goerli)
☑️ macOS Version 12.0.1
(Build 21C52) (Ropsten)
  • Verified steps from issue description
  • Verified View on block explorer opens the transaction link on the selected network as expected
22534-Linux.mp4
22534-Windows.mov
22534-macOS.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants