Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(wallet): Block Explorer URL (uplift to 1.38.x) #13181

Merged
merged 1 commit into from
Apr 27, 2022
Merged

fix(wallet): Block Explorer URL (uplift to 1.38.x) #13181

merged 1 commit into from
Apr 27, 2022

Conversation

Douglashdaniel
Copy link
Contributor

@Douglashdaniel Douglashdaniel commented Apr 26, 2022 •
edited by kjozwiak
Loading

Resolves brave/brave-browser#22534

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@Douglashdaniel Douglashdaniel added this to the 1.38.x - Release milestone Apr 26, 2022
@Douglashdaniel Douglashdaniel requested a review from a team April 26, 2022 21:25
@Douglashdaniel Douglashdaniel self-assigned this Apr 26, 2022
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Apr 26, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

kjozwiak
kjozwiak approved these changes Apr 27, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.38.x approved 👍

@kjozwiak kjozwiak merged commit 36cc1de into 1.38.x Apr 27, 2022
@kjozwiak kjozwiak deleted the fix-block-explorer-url-1.38.x branch April 27, 2022 02:05
@kjozwiak kjozwiak mentioned this pull request Apr 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@Douglashdaniel Douglashdaniel

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
1.38.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@Douglashdaniel @brave-builds @kjozwiak