Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

starting position of NTP is incorrect when Brave News is enabled and new tabs are created from another NTP tab #22549

Closed
kjozwiak opened this issue Apr 26, 2022 · 1 comment · Fixed by brave/brave-core#13171

Comments

@kjozwiak
Copy link
Member

Description

When opening new tabs while you're active tab is a NTP with Brave News enabled, the NTP that you created will have either the second or third news card visible rather than starting at the top and having both the stats & tiles visible. We had this issue in the past which was fixed but now regressed again due to brave/brave-core#13155. I can only reproduce this on 1.40.11 or higher which means brave/brave-core#13155 is the culprit.

Steps to reproduce

  1. launch 1.40.11 Chromium: 101.0.4951.41 or higher
  2. enable Brave News and scroll through the feed (stop anywhere after scrolling)
  3. open a new tab via + and notice that you're placed near the beginning of the feed rather than the top of the NTP

Actual result

Screen_Recording_20220425-234518_Brave.-.Nightly.mp4

Expected result

When opening a NTP, users should always be at the top of the NTP. Meaning that Stats & Tiles should be visible.

Issue reproduces how often

100% reproducible using the STR/Cases outlined above.

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? No
  • Can you reproduce this issue with the current Play Store Beta version? No
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Quick note: Currently brave/brave-core#13155 is in Nightly only (1.40.x)

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Pixel 6
  • Android version: Android 12

Brave version

  • 1.40.11 Chromium: 101.0.4951.41

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Additional information

@kjozwiak
Copy link
Member Author

Verification PASSED on Samsung S10+ running Android 12 using the following build(s):

Brave | 1.38.118 Chromium: 101.0.4951.67 (Official Build) (64-bit)
--- | ---
Revision | 8888ee7a24e2c36661ddb9536c35b7d4852a3a98-refs/branch-heads/4951@{#1230}
OS | Android 12; Build/SP1A.210812.016

Went through the STR/Cases outlined viahttps://github.com//issues/22549#issue-1215367147 and ensured that users starts at the top of the NTP when opening a new tab while viewing the news feed.

Screen_Recording_20220515-235856_Brave.mp4
Brave | 1.38.118 Chromium: 101.0.4951.67 (Official Build) (64-bit)
--- | ---
Revision | 8888ee7a24e2c36661ddb9536c35b7d4852a3a98-refs/branch-heads/4951@{#1230}
OS | Android 11; Build/RP1A.200720.012

Went through the STR/Cases outlined viahttps://github.com//issues/22549#issue-1215367147 and ensured that users starts at the top of the NTP when opening a new tab while viewing the news feed.

XRecorder_16052022_000422.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants