Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewards panel loads slowly state when network is slow #22834

Closed
zenparsing opened this issue May 13, 2022 · 3 comments · Fixed by brave/brave-core#13329
Closed

Rewards panel loads slowly state when network is slow #22834

zenparsing opened this issue May 13, 2022 · 3 comments · Fixed by brave/brave-core#13329

Comments

@zenparsing
Copy link

Because some calls to the chrome.braveRewards API require network access, when the network is unavailable or slow the Rewards panel can stay in the "loading" state for some time. We should be able to display the current state to the user and update the UI when the data becomes available.

@zenparsing
Copy link
Author

See #19287 for a more general issue.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented May 27, 2022

Verification PASSED on

Brave | 1.40.75 Chromium: 102.0.5005.61 (Official Build) beta (64-bit)
-- | --
Revision | 0e59bcc00cc4985ce39ad31c150065f159d95ad3-refs/branch-heads/5005@{#819}
OS | Windows 10 Version 21H2 (Build 19044.1706)

@stephendonner
Copy link

stephendonner commented Jun 1, 2022

Verified PASSED using

Brave 1.40.82 Chromium: 102.0.5005.78 (Official Build) beta (x86_64)
Revision df6dbb5a9fd82af3f567198af2eb5fb4876ef99c-refs/branch-heads/5005_59@{#3}
OS macOS Version 11.6.6 (Build 20G624)

Followed the testplan from brave/brave-core#13329

Confirmed that clicking on the Brave Rewards panel displays content within 3 seconds when the network is disconnected


First, tried to reproduce the issue using Rewards staging env:

Brave 1.39.111 Chromium: 102.0.5005.61 (Official Build) (x86_64)
Revision 0e59bcc00cc4985ce39ad31c150065f159d95ad3-refs/branch-heads/5005@{#819}
OS macOS Version 11.6.6 (Build 20G624)

Verification passed on

Brave 1.40.87 Chromium: 102.0.5005.78 (Official Build) beta (64-bit)
Revision df6dbb5a9fd82af3f567198af2eb5fb4876ef99c-refs/branch-heads/5005_59@{#3}
OS Ubuntu 18.04 LTS

Verified the testplan from brave/brave-core#13329

Confirmed that clicking on the Brave Rewards panel displays content within 3 seconds when the network is disconnected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment