Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blogspot.com URLs not being debounced #22894

Closed
pilgrim-brave opened this issue May 17, 2022 · 9 comments · Fixed by brave/brave-core#13361
Closed

blogspot.com URLs not being debounced #22894

pilgrim-brave opened this issue May 17, 2022 · 9 comments · Fixed by brave/brave-core#13361
Assignees
Labels

Comments

@pilgrim-brave
Copy link

pilgrim-brave commented May 17, 2022

Test case: https://example.blogspot.com/a/b/c/?url=https://brave.com should redirect to https://brave.com

@pilgrim-brave pilgrim-brave self-assigned this May 17, 2022
@pilgrim-brave pilgrim-brave changed the title blogspot URLs not being debounced blogspot.com URLs not being debounced May 17, 2022
@pilgrim-brave
Copy link
Author

Root cause is that Chromium can optionally treat blogspot as a "private registry" so the "top-level domain" is "example.blogspot.com" instead of "blogspot.com". We turn on this option while creating the host cache, but we have a debounce rule that applies to all *.blogspot.com URLs, i.e. it expects us to treat blogspot.com as the top-level domain, not individual blogs on their own subdomain.

Easiest fix is to turn off the "include private registries" option when creating the debounce host cache, since our rules are not expecting that behavior.

@pilgrim-brave pilgrim-brave added feature/shields/adblock Blocking ads & trackers with Shields QA/Yes OS/Android Fixes related to Android browser functionality OS/Desktop release-notes/include labels May 17, 2022
@pilgrim-brave pilgrim-brave added this to the 1.40.x - Beta milestone Jun 8, 2022
@LaurenWags LaurenWags added QA/In-Progress Indicates that QA is currently in progress for that particular issue and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jun 9, 2022
@LaurenWags
Copy link
Member

LaurenWags commented Jun 9, 2022

@stephendonner
Copy link

Hi @pilgrim-brave using:

Brave 1.41.50 Chromium: 102.0.5005.99 (Official Build) nightly (x86_64)
Revision 870f7bcc58dfa811cc68c2186439721385e086d0-refs/branch-heads/5005@{#1125}
OS macOS Version 12.5 (Build 21G5037d)

I tried to reproduce and verify using https://example.blogspot.com/a/b/c/?url=https://brave.com from #22894 (comment), but it returns a 404 (trying to find that URL on blogspot.com, rather than redirecting to the brave.com URL):

Screen Shot 2022-06-09 at 3 48 59 PM

Mind trying and letting me know if the test plan needs changing? Thanks!

@LaurenWags
Copy link
Member

Marking as QA/Blocked until the above is resolved.

@pilgrim-brave
Copy link
Author

Ah, the debounce rules have changed. New test URL is https://example.blogspot.com/a/b/c?url=aHR0cHM6Ly93d3cuYnJhdmUuY29t

@pilgrim-brave
Copy link
Author

which should navigate to brave.com

@stephendonner
Copy link

stephendonner commented Jun 10, 2022

Tried both https://example.blogspot.com/a/b/c?url=aHR0cHM6Ly93d3cuYnJhdmUuY29t https://example.blogspot.com/a/b/c/?url=aHR0cHM6Ly93d3cuYnJhdmUuY29t (with the trailing slash after /c, before the ? in the query string)

Both still give me 404s:

https://example.blogspot.com/a/b/c?url=aHR0cHM6Ly93d3cuYnJhdmUuY29t https://example.blogspot.com/a/b/c/?url=aHR0cHM6Ly93d3cuYnJhdmUuY29t
Screen Shot 2022-06-10 at 10 41 01 AM Screen Shot 2022-06-10 at 10 43 03 AM

@pilgrim-brave please let us know when you're able to get a currently-working testplan, and we'll remove the QA/Blocked label again; thanks.

@stephendonner
Copy link

stephendonner commented Jun 21, 2022

Verified PASSED

Not sure why I wasn't seeing it working, above, but am now, using

Brave 1.41.74 Chromium: 103.0.5060.53 (Official Build) beta (x86_64)
Revision a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853}
OS macOS Version 11.6.7 (Build 20G630)

Steps:

  1. install 1.41.74
  2. launch Brave
  3. load https://example.blogspot.com/a/b/c?url=aHR0cHM6Ly93d3cuYnJhdmUuY29t with the Network panel from Developers Tools open, with Preserve log selected

Confirmed I was redirected to brave.com

Screen Shot 2022-06-21 at 1 12 10 PM

@kjozwiak
Copy link
Member

Verification PASSED on Pixel 6 running Android 13 using the following build(s):

Brave | 1.41.82 Chromium: 103.0.5060.66 (Official Build) beta (32-bit)
--- | ---
Revision | 20b1569438a85e631d15e83eb355e3e326e5da6f-refs/branch-heads/5060@{#1066}
OS | Android 13;
  • downloaded/installed 1.41.82 Chromium: 103.0.5060.66
  • restarted the browser and ensured that the Griffin studies have been pulled/downloaded via brave://version
  • loaded https://example.blogspot.com/a/b/c?url=aHR0cHM6Ly93d3cuYnJhdmUuY29t and ensured it was redirected to brave.com

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants