-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blogspot.com URLs not being debounced #22894
Comments
Root cause is that Chromium can optionally treat blogspot as a "private registry" so the "top-level domain" is "example.blogspot.com" instead of "blogspot.com". We turn on this option while creating the host cache, but we have a debounce rule that applies to all *.blogspot.com URLs, i.e. it expects us to treat blogspot.com as the top-level domain, not individual blogs on their own subdomain. Easiest fix is to turn off the "include private registries" option when creating the debounce host cache, since our rules are not expecting that behavior. |
Milestone is incorrect. Adjusting to 1.41.x per https://github.com/brave/brave-core/commits/master?after=3f255de8a52b3457df76b084698d4eb5cb5125ff+419&branch=master&qualified_name=refs%2Fheads%2Fmaster |
Hi @pilgrim-brave using:
I tried to reproduce and verify using Mind trying and letting me know if the test plan needs changing? Thanks! |
Marking as |
Ah, the debounce rules have changed. New test URL is |
which should navigate to |
Tried both Both still give me 404s:
@pilgrim-brave please let us know when you're able to get a currently-working testplan, and we'll remove the |
Verified
|
Brave | 1.41.74 Chromium: 103.0.5060.53 (Official Build) beta (x86_64) |
---|---|
Revision | a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853} |
OS | macOS Version 11.6.7 (Build 20G630) |
Steps:
- install
1.41.74
- launch Brave
- load
https://example.blogspot.com/a/b/c?url=aHR0cHM6Ly93d3cuYnJhdmUuY29t
with theNetwork
panel fromDevelopers Tools
open, withPreserve log
selected
Confirmed I was redirected to brave.com
Verification PASSED on
|
Test case:
https://example.blogspot.com/a/b/c/?url=https://brave.com
should redirect tohttps://brave.com
The text was updated successfully, but these errors were encountered: