-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shields breaking text/fonts on some websites #23093
Comments
I'll test Brave/m1 later, but for Windows (w11): @holdit |
@ryanbr I see the same. Reddit isn't the best example because the site looks fine, but all that is supposed to be using Verdana as font. Instead, it's using Arial(?) for the titles, comments, etc, and Times New Roman(?) in the search bar. If you disable fingerprint blocking, restart Brave (very important), and visit the page again, the text will be wider because it's using the proper font. The place were this issue manifests itself well is on Todoist(.com) dashboard. You'd need to have an account to check it out, but look at the spaces between the fonts on these two screenshots. If I allow fingerprinting (text looks fine): If I use the standard or strict fingerprinting blocking (spacing is all messed up): |
Found another website where the font change also happens: https://www.ispreview.co.uk/ |
Another example, NPR's text website: https://text.npr.org/1101971227 Could this be some new fingerprint blocking that was added to the aggressive protection, but is also being used by the regular option? I don't know, maybe something that doesn't reveal the real list of fonts available by the system? Again, a browser restart after enabling/disabling fingerprint blocking may be required for us to see the differences. Here's a gif showing the difference: |
I have the same issue on macOS arm64 (M1), most notably on GitHub and some other platforms. I had to switch to other browsers because it was making the UI messed up. For instance, this is what this current page looks like: The web fonts aren't working and have fallbacked to system fonts. These fonts do work with Shields turned off. |
Notion also doesn't have fonts anymore. |
Same bug on macOS arm64 (M1). |
Yes I am seeing this on Notion. It resolves itself when I turn Shields off. Edit to add: after playing around, leaving shields UP but Allowing Fingerprinting also resolves it. Toggling the finger printing to allow/block seems to be the thing that changes it. Also, removing ANY of the listed fonts for the page in the CSS on the Inspect screen fixes it temporarily (until refresh or opening a new page). Version 1.39.111 Chromium: 102.0.5005.61 (Official Build) (x86_64) |
yes but it doesn't make sense, because one of Brave's major strengths are Shields and/or the (partial) protection against fingerprinting. If I had to turn them off, I might as well use another browser. |
Fingerprint protection is also enabled by default (Standard) for everyone, I think, so it's probably something that should be prioritised. For now I've disabled the setting. Annoying, but the browser still works. Side note: for anyone using the option to clean data when closing the browser, keep in mind that checking the "Site and shields settings" also resets the fingerprint protection option... so it will be enabled next time you open the browser. |
This is happening on our website on MacOS 11.6.6. Allowing fingerprinting fixes it. We are using a "system font" stack based on CSS-Tricks and normalize.css:
|
Reporting the same issue on macOS 12.4. Computed font-familiy: Shields up: Rendered font: Shields down: Rendered font: Workaround: Disable "Prevent sites from fingerprinting me based on my language preferences" in |
I've tested @huylv workaround and it works. Even if block fingerpriting is set to "strict", fonts work fine if the "Prevent sites from fingerprinting me based on my language preferences" option is disabled. |
Yes @huylv's workaround works for me too |
Also happening on ghacks: #23391 |
This was fixed with brave/brave-core#13550 - which should have been released in product version For folks experiencing the issue - can you please update? I'll close this issue out as a duplicate of the original issue #22605 |
@bsclifton Is this supposed to be working on I'm still seeing the same problem on some sites with Standard + "Prevent sites from fingerprinting me based on my language preferences". For example, the Feedly login page: Same with ispreview.co.uk and other sites/pages I posted above. I'm seeing the same on So, for me at least, the problem isn't fixed. |
The problem is back for me on Todoist with 1.41.96. Active variations: |
@kjozwiak
|
I have another user reporting this issue, seems it has returned.
|
I experienced this issue and arrived here after some basic troubleshooting and finding that turning down shields allowed our font stack to work as expected. At the time, I was running macOS 12.4 and a slightly outdated version of Brave. The font stack is Next, I updated Brave to Hope this helps! |
I have opened a followup issue so we can track these 3 new reports (two about Todoist and the latest one from jonathanawesome). Also I am testing a fix locally. |
AshikaDoist, this issue has been fixed in brave/brave-core#14489, and the fix is being rolled out to all Brave users. Thank you for your report; it was very helpful. And thank you for your patience. |
I have the same issue - but with custom fonts (installed locally on my mac (OS 12.5) on the latest Brave Browser (Version 1.42.88 Chromium: 104.0.5112.81 (Official Build) (x86_64)). If i disable the "Block fingerprint" option it is fine again. With "Default" it uses a wrong font. |
@dmetzler1988 you should be fixed now if you update to the latest version ( |
@bsclifton i currently have the version 1.42.97 - and still same issue. If shields are activated, the fonts are wrong (times new roman i think). If i deactivate the shields, it works as expected. The problem occurs on inbox of outlook.office.com - maybe this will help. |
@dmetzler1988 thanks for confirming - what website are you noticing this on? |
@bsclifton i noticed this on outlook.office.com - on each mail with the custom fonts. |
@bsclifton : At the risk of adding a "me too" ... me too! I'm on MacOS 10.14.6 (stuck on Mojave since I need 32 bit libraries) + Brave "Version 1.42.97 Chromium: 104.0.5112.102 (Official Build) (x86_64)". I have custom CSS on Wikipedia that uses Merriweather as the main text font. Just recently (in the last week) Brave began not to load Merriweather (on odd occasion it does, unhelpfully). If I turn off "Brave Shield" for https://en.wikipedia.org/, the problem disappears. On that site, I'm content to leave shields down ... but this ought not to be, as I understand it. |
Reports are resurfacing of this happening on Todoist:
User says:
|
Another TD user:
|
Hi Ashika, thank you for these reports. To the best of my knowledge, this bug was fixed in Brave 1.42.97. Can you find out which version these users are on? Visiting |
My entry, three comments above, includes the identification of Brave 1.42.97 as the version which is throwing up problems for me on this front. |
Apologies if this reopens the issue, but I am still having this problem on Notion. It actually only started in the past couple of days. I originally had this issue all the way back when it was first an issue, but then it was fixed, and now its back again, but this time instead of weird spacing its changing the font to be different/larger. Unfortunately I cannot share a screenshot as its happening on pages I can't share publicly. But, it's happening on the gallery view of databases in notion. Brave says it's up to date. Brave version 1.42.97 Chromium: 104.0.5112.102 (Official Build) (x86_64) |
@YoavRheims mind providing the websites that you guys are having issues with? @spiderkitten sounds like you had issues with https://todoist.zendesk.com/agent/tickets/698475? Are you still seeing the same problems? It's been sometime since the |
I don't know what the todoist link is, I get an error that the page doesnt exisit. But the issue I was having in Notion seems to be all good for me right now, thank you. |
@spiderkitten glad to hear it's OK now 😄 The thing I'd ask folks to check shield settings specifically on the site where they have the problem and ensure you have |
I wonder if people still having issues are on a site that has a font-family set that the user has locally, but the site itself does not have the script providing the files I noticed a discrepancy on a personal site I use for a simple redirect (basically Jira set to the start of this week + 5 days, with a specific view). I have the page output "Redirecting to Jira, week of 2023-06-19", but since I'm the only one using it, I didn't bother throwing in a google font call, I just have it set to use a local font for Montserrat. If I have the google font script in there, it works for both shields up or down. If I don't have that script and am relying on the local font, shield up blocks it, shields down (or allow fingerprinting) and it loads fine. |
This issue persists. Locally installed fonts are appearing on pages with fingerprinting allowed, however the fonts are not appearing on pages with fingerprinting blocked I see that the previous fix was to add Helvetica to the fonts whitelist. Perhaps Montserrat & Roboto could be added as well. |
@stako if you're still having issues with the above, I would suggest creating a new issue using the template. Add as much information as possible. This way it will get looked at and triaged rather than replying to an older issue that has been closed for some time 👍 |
Same here. Override font using stylus addon does not working with
|
Description
Since version 1.39.111 the text on some websites started to look wrong: wrong font, wrong spacing, wrong line hight, etc. It only happens on some sites. So far I've only noticed it happening on pages without custom fonts (eg: happens on old.reddit.com with the default theme, but not when a custom theme with a different font is used. the new reddit UI is also fine).
This seems to be related to Shield's "Block fingerprinting" option (standard or strict) as disabling it fixes the problem.
Steps to Reproduce
Note: Only seems to happens on pages without custom fonts. A sub (eg: Brave's sub) with a custom theme looks fine (unless you disable custom themes on your reddit account). Please note that this issue is not limited to reddit.
Actual result:
Wrong spaces, line height, wrong font (number 26):
Wrong font:
Expected result:
Correct spaces, font, etc:
Using the correct verdana font:
Reproduces how often:
Most of the times the text looks wrong. A browser restart is sometimes needed after enabling Shields' privacy option to see updated results.
Brave version (brave://version info)
Tested with:
Machine:
According to this comment, it's also happening on Windows 10: https://old.reddit.com/r/brave_browser/comments/uwuad0/release_channel_139111/i9x2ow8/
Version/Channel Information:
Can reproduce the issue on the current stable and nightly versions.
Other Additional Information:
No issues when the privacy option of Brave Shields is disabled.
Miscellaneous Information:
More reports on reddit: https://old.reddit.com/r/brave_browser/comments/uwuad0/release_channel_139111/i9ty88d/
The text was updated successfully, but these errors were encountered: