Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match font whitelist case insensitively #13892

Merged
merged 3 commits into from
Jun 22, 2022

Conversation

pilgrim-brave
Copy link
Contributor

@pilgrim-brave pilgrim-brave commented Jun 22, 2022

Resolves brave/brave-browser#23093
Resolves brave/brave-browser#23541

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@pilgrim-brave pilgrim-brave added this to the 1.42.x - Nightly milestone Jun 22, 2022
@pilgrim-brave pilgrim-brave requested a review from a team as a code owner June 22, 2022 01:53
@pilgrim-brave pilgrim-brave self-assigned this Jun 22, 2022
@pilgrim-brave pilgrim-brave requested a review from bridiver June 22, 2022 01:53
@pilgrim-brave pilgrim-brave merged commit 282ce66 into master Jun 22, 2022
@pilgrim-brave pilgrim-brave deleted the mpilgrim_font_whitelist_case branch June 22, 2022 19:32
@pilgrim-brave pilgrim-brave restored the mpilgrim_font_whitelist_case branch June 22, 2022 19:48
brave-builds pushed a commit that referenced this pull request Jun 22, 2022
brave-builds pushed a commit that referenced this pull request Jun 22, 2022
@kjozwiak kjozwiak deleted the mpilgrim_font_whitelist_case branch June 23, 2022 06:11
@kjozwiak
Copy link
Member

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.42.20 Chromium: 103.0.5060.53 (Official Build) nightly (64-bit)
-- | --
Revision | a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853}
OS | Windows 11 Version 21H2 (Build 22000.739)

Test Case #1 - brave/brave-browser#23541

Launched Nightly using the following terminal/CLI switch to ensure that Griffin doesn't come into play and we're checking the browser fix as we've pushed the DisableReduceLanguage:Default study as per brave/brave-variations#292.

brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seeasdsadd

Went through the STR/Cases outlined via brave/brave-browser#23541 (comment)

image

@brave/qa-team As discussed via Slack with @bsclifton, we'll leave brave/brave-browser#23093 opened until we start receiving feedback from users re: brave/brave-variations#292 fixing their issue.

In terms of verification, we'll change the label to QA/No on brave/brave-browser#23093 as the feature will be disabled at that point (1.40.x - Release #3) and we'll start enabling it via Griffin and monitor feedback.

wknapik pushed a commit that referenced this pull request Jun 23, 2022
* Expand font whitelist on Windows

* Match font whitelist case insensitively

* .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shields breaking fonts on Feedly - follow up to #23489 Shields breaking text/fonts on some websites
3 participants