Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DApps: Fix address placement in the account switcher, address partially moved to next line when selected #23558

Closed
Pavneet-Sing opened this issue Jun 20, 2022 · 2 comments · Fixed by brave/brave-core#13968
Closed

DApps: Fix address placement in the account switcher, address partially moved to next line when selected #23558

Pavneet-Sing opened this issue Jun 20, 2022 · 2 comments · Fixed by brave/brave-core#13968
Assignees
@qamarngr
Labels
feature/web3/wallet/dapps feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include
Milestone
1.42.x - Release

Comments

@Pavneet-Sing
Copy link

Pavneet-Sing commented Jun 20, 2022 •
edited
Loading

https://bravesoftware.slack.com/archives/C02SC5AKTAS/p1655379158901509?thread_ts=1653566500.573419&cid=C02SC5AKTAS

Screenshot from 2022-06-23 17-35-19

Screenrecorder-2022-06-16-16-15-23-661.mp4
@Pavneet-Sing Pavneet-Sing mentioned this issue Jun 20, 2022
Closed
3 tasks
@Pavneet-Sing Pavneet-Sing added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality feature/web3/wallet/dapps labels Jun 20, 2022
@Pavneet-Sing Pavneet-Sing self-assigned this Jun 20, 2022
@Pavneet-Sing Pavneet-Sing changed the title Fix address placement in the account switcher, moved to next line when selected DApps: Fix address placement in the account switcher, address partially moved to next line when selected Jun 20, 2022
@Pavneet-Sing Pavneet-Sing removed their assignment Jun 27, 2022
@Pavneet-Sing
Copy link
Author

Dropping this to prioritise Solana implementation

@qamarngr qamarngr self-assigned this Jun 27, 2022
This was referenced Jun 27, 2022
Merged
Closed
@brave-builds brave-builds added this to the 1.42.x - Nightly milestone Jun 28, 2022
@srirambv
Copy link
Contributor

Verification passed on Oppo Reno 5 with Android 12 running 1.42.80 x64 build

  • Verified steps from brave/brave-core#13968
  • Verified selecting an account doesn't affect the address placement
23558.mp4

@srirambv srirambv mentioned this issue Aug 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qamarngr qamarngr

Labels
feature/web3/wallet/dapps feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.42.x - Release
Development

Successfully merging a pull request may close this issue.

Fixed account switch transition brave/brave-core
4 participants
@qamarngr @Pavneet-Sing @srirambv @brave-builds