Fixed account switch transition #13968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qamarngr
added
CI/skip-linux
CI/skip-macos-x64
qamarngr
force-pushed
the
fix-account-selection-tick-switch
branch
from
38c48a5
to
9ff1e5c
Compare
android/java/org/chromium/chrome/browser/crypto_wallet/adapters/WalletCoinAdapter.java
Outdated
Show resolved
Hide resolved
Comment on lines
299
to
303
| notifyItemRangeChanged( | ||
| previousSelectedPos, selectedAccountPosition - previousSelectedPos); | ||
| } else { | ||
| notifyItemRangeChanged( | ||
| selectedAccountPosition, previousSelectedPos - selectedAccountPosition + 1); |
There was a problem hiding this comment.
[Adding the comment here to be marked as resolved]
Unfortunately, this still happens (video at 15 second and at the end), I guess an ideal solution could be to use custom checkbox instead of ImageView. Probably discuss with @srirambv or @jamesmudgett to make sure it's good enough to go or requires more polishing.
selector-issue.mp4
There was a problem hiding this comment.
due to account switch transition is a minor p4 issue so would not merge that issue, Will only merge brave/brave-browser#23558 after review.
Pavneet-Sing
approved these changes
Jun 28, 2022
qamarngr
force-pushed
the
fix-account-selection-tick-switch
branch
from
00a1fdc
to
671f767
Compare
qamarngr
force-pushed
the
fix-account-selection-tick-switch
branch
from
671f767
to
a274cc6
Compare
Pavneet-Sing
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#23558
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan:
Screenrecorder-2022-06-28-21-50-46-984.mp4