Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple brave_ads::*AdsClientNotifierObserver from processors to resources #23888

Closed
tmancey opened this issue Jul 5, 2022 · 1 comment · Fixed by brave/brave-core#18311
Closed

Decouple brave_ads::*AdsClientNotifierObserver from processors to resources #23888

tmancey opened this issue Jul 5, 2022 · 1 comment · Fixed by brave/brave-core#18311
Assignees
@tmancey
Labels
dev-concern feature/ads OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA/Yes release-notes/exclude
Milestone
1.56.x - Release

Comments

@tmancey
Copy link
Contributor

tmancey commented Jul 5, 2022

No description provided.

@tmancey tmancey changed the title Decouple Brave Ads *ManagerObserver from processors to resources Decouple brave_ads::*ManagerObserver from processors to resources Apr 13, 2023
@tmancey tmancey added the closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. label Apr 24, 2023
@tmancey tmancey self-assigned this Apr 24, 2023
@tmancey tmancey closed this as completed Apr 24, 2023
@tmancey tmancey changed the title Decouple brave_ads::*ManagerObserver from processors to resources Decouple brave_ads::*AdsClientNotifierObserver from processors to resources Apr 30, 2023
@tmancey tmancey reopened this Apr 30, 2023
@tmancey tmancey added priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/exclude and removed closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. labels Apr 30, 2023
@tmancey tmancey mentioned this issue May 1, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.53.x - Nightly milestone May 3, 2023
@stephendonner stephendonner changed the title Decouple brave_ads::*AdsClientNotifierObserver from processors to resources Decouple brave_ads::*AdsClientNotifierObserver from processors to resources May 17, 2023
@btlechowski
Copy link

btlechowski commented Jun 20, 2023 •
edited
Loading

Verification passed on

Brave 1.53.99 Chromium: 114.0.5735.133 (Official Build) beta (64-bit)
Revision fbfa2ce68d01b2201d8c667c2e73f648a61c4f4a-refs/branch-heads/5735@{#1270}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#18311

Verified the ads resources component was downloaded on clean profile after enabling ads
image

Verified the embedding resource was initialized:

[14442:14442:0620/141807.870325:VERBOSE2:ads_service_impl.cc(1861)] Loading file resource from /home/bartlomiej/.config/BraveSoftware/Brave-Browser-Beta/ocilmpijebaopmdifcomolmpigakocmo/1.0.62/bvkgcaxyaitmhkbbqnqnqugrjeqzspxv for component id wtpwsrqtjxmfdwaymauprezkunxprysm
[14442:14442:0620/141808.032991:VERBOSE1:text_embedding_resource.cc(62)] Successfully initialized wtpwsrqtjxmfdwaymauprezkunxprysm text embedding resource version 1

Verified the text classification resource was initialized:

[14442:14442:0620/141807.869780:VERBOSE2:ads_service_impl.cc(1861)] Loading file resource from /home/bartlomiej/.config/BraveSoftware/Brave-Browser-Beta/ocilmpijebaopmdifcomolmpigakocmo/1.0.62/emgmepnebbddgnkhfmhdhmjifkglkamo for component id feibnmjhecfbjpeciancnchbmlobenjn
[14442:14442:0620/141808.197603:VERBOSE1:text_classification_resource.cc(65)] Successfully initialized feibnmjhecfbjpeciancnchbmlobenjn text classification resource version 1

Verified the conversions resource was initialized:

[14442:14442:0620/141802.998841:VERBOSE2:ads_service_impl.cc(1861)] Loading file resource from /home/bartlomiej/.config/BraveSoftware/Brave-Browser-Beta/iblokdlgekdjophgeonmanpnjihcjkjj/1.0.80/dnryisldmaqljgwaxeqbuuhuvrbboqlf for component id nnqccijfhvzwyrxpxwjrpmynaiazctqb
[14442:14442:0620/141803.007021:VERBOSE1:conversions_resource.cc(56)] Successfully loaded nnqccijfhvzwyrxpxwjrpmynaiazctqb conversions resource

Verified the purchase intent resource was initialized:

[14442:14442:0620/141803.002303:VERBOSE2:ads_service_impl.cc(1861)] Loading file resource from /home/bartlomiej/.config/BraveSoftware/Brave-Browser-Beta/iblokdlgekdjophgeonmanpnjihcjkjj/1.0.80/kkjipiepeooghlclkedllogndmohhnhi for component id bejenkminijgplakmkmcgkhjjnkelbld
[14442:14442:0620/141803.010811:VERBOSE1:purchase_intent_resource.cc(64)] Successfully initialized bejenkminijgplakmkmcgkhjjnkelbld purchase intent resource version 1

Verified the ads resources component was updated
image

Verified the embedding resource was updated and initialized:

[15049:15049:0620/145923.114378:VERBOSE1:resource_component.cc(204)] Updating wtpwsrqtjxmfdwaymauprezkunxprysm resource to version 1
[15049:15049:0620/145923.114378:VERBOSE2:ads_service_impl.cc(1861)] Loading file resource from /home/bartlomiej/.config/BraveSoftware/Brave-Browser-Beta/ocilmpijebaopmdifcomolmpigakocmo/1.0.118/bvkgcaxyaitmhkbbqnqnqugrjeqzspxv for component id wtpwsrqtjxmfdwaymauprezkunxprysm
[15049:15049:0620/145923.327672:VERBOSE1:text_embedding_resource.cc(62)] Successfully initialized wtpwsrqtjxmfdwaymauprezkunxprysm text embedding resource version 1

Verified the text classification resource was updated and initialized:

[15049:15049:0620/145923.114294:VERBOSE1:resource_component.cc(204)] Updating feibnmjhecfbjpeciancnchbmlobenjn resource to version 1
[15049:15049:0620/145923.114294:VERBOSE2:ads_service_impl.cc(1861)] Loading file resource from /home/bartlomiej/.config/BraveSoftware/Brave-Browser-Beta/ocilmpijebaopmdifcomolmpigakocmo/1.0.118/emgmepnebbddgnkhfmhdhmjifkglkamo for component id feibnmjhecfbjpeciancnchbmlobenjn
[15049:15049:0620/145923.575968:VERBOSE1:text_classification_resource.cc(65)] Successfully initialized feibnmjhecfbjpeciancnchbmlobenjn text classification resource version 1

Verified the conversions resource was updated and initialized:

[15049:15049:0620/145923.114626:VERBOSE1:resource_component.cc(204)] Updating nnqccijfhvzwyrxpxwjrpmynaiazctqb resource to version 1
[15049:15049:0620/145923.114626:VERBOSE2:ads_service_impl.cc(1861)] Loading file resource from /home/bartlomiej/.config/BraveSoftware/Brave-Browser-Beta/iblokdlgekdjophgeonmanpnjihcjkjj/1.0.150/dnryisldmaqljgwaxeqbuuhuvrbboqlf for component id nnqccijfhvzwyrxpxwjrpmynaiazctqb
[15049:15049:0620/145923.153086:VERBOSE1:conversions_resource.cc(64)] Successfully initialized nnqccijfhvzwyrxpxwjrpmynaiazctqb conversions resource version 1

Verified the purchase intent resource was updated and initialized:

[15049:15049:0620/145923.114959:VERBOSE1:resource_component.cc(204)] Updating bejenkminijgplakmkmcgkhjjnkelbld resource to version 1
[15049:15049:0620/145923.114959:VERBOSE2:ads_service_impl.cc(1861)] Loading file resource from /home/bartlomiej/.config/BraveSoftware/Brave-Browser-Beta/iblokdlgekdjophgeonmanpnjihcjkjj/1.0.150/kkjipiepeooghlclkedllogndmohhnhi for component id bejenkminijgplakmkmcgkhjjnkelbld
[15049:15049:0620/145923.164521:VERBOSE1:purchase_intent_resource.cc(64)] Successfully initialized bejenkminijgplakmkmcgkhjjnkelbld purchase intent resource version 1

@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
dev-concern feature/ads OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA/Yes release-notes/exclude
Projects
Ads
Archived in project
Milestone
1.56.x - Release
Development

Successfully merging a pull request may close this issue.

Decouple brave_ads::*AdsClientNotifierObserver from processors to resources brave/brave-core
3 participants
@tmancey @btlechowski @brave-builds