Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple brave_ads::*AdsClientNotifierObserver from processors to resources #18311

Merged
merged 2 commits into from
May 3, 2023

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented May 1, 2023

Resolves brave/brave-browser#23888

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Confirm anti-targeting, conversions, purchase intent, text classification and text embedding resources are locally updated if the meta data is updated on the server, i.e. a new version. For each of the test resources Successfully loaded <resource_id> <resource_type> resource should be shown in the console log.

@tmancey tmancey requested a review from a team as a code owner May 1, 2023 07:55
@tmancey tmancey self-assigned this May 1, 2023
@tmancey tmancey force-pushed the issues/23888 branch 11 times, most recently from 5924722 to 43c1b6f Compare May 3, 2023 17:32
@tmancey tmancey enabled auto-merge May 3, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decouple brave_ads::*AdsClientNotifierObserver from processors to resources
2 participants