Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shields shows enabled icon even when disabled #240

Closed
srirambv opened this issue May 28, 2018 · 3 comments · Fixed by brave/brave-extension#37
Closed

Shields shows enabled icon even when disabled #240

srirambv opened this issue May 28, 2018 · 3 comments · Fixed by brave/brave-extension#37

Comments

@srirambv
Copy link
Contributor

Description

Shields shows enabled icon even when disabled

Steps to Reproduce

  1. Build from source
  2. Visit any site in a new tab
  3. Disable shields on the site, still shows active shields icon

Actual result:

Shields shows enabled icon even when disabled
image

Expected result:

Should show disabled shield icon and no badge count should be shown

Reproduces how often:

Brave version (about:brave info)

2e9c470

@srirambv srirambv added bug feature/shields The overall Shields feature in Brave. release/blocking labels May 28, 2018
@bbondy bbondy removed their assignment May 29, 2018
@bbondy bbondy assigned cezaraugusto and unassigned yrliou Jun 6, 2018
@bbondy bbondy added this to the Milestone 3: June-July milestone Jun 6, 2018
@fundrequestbot
Copy link


This issue has been funded using FundRequest. A developer can claim the reward by submitting a pull request referencing this issue. (How to Close Issues via Pull Requests?) e.g. fixes #240

  • For more help on how to claim on issue, please visit our help section.
  • Looking for more? Feel free to browse through all funded requests.

@fundrequestbot
Copy link

fundrequestbot commented Jun 28, 2018


Thank you @cezaraugusto for your code contribution. The reward linked to this issue has been transferred to your account.

  • Looking for more? Feel free to browse through all funded requests.

@btlechowski
Copy link

btlechowski commented Sep 21, 2018

Verification passed on

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows 7

Verification Passed on

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Mac OS X
Brave 0.55.2 Chromium: 70.0.3538.22 (Developer Build) (64-bit)
Revision ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment