Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shields should not show badge when block count is 0 #470

Closed
srirambv opened this issue Jul 2, 2018 · 1 comment · Fixed by brave/brave-extension#44
Closed

Shields should not show badge when block count is 0 #470

srirambv opened this issue Jul 2, 2018 · 1 comment · Fixed by brave/brave-extension#44
Assignees
@cezaraugusto
Labels
browser-laptop-parity feature/shields The overall Shields feature in Brave. polish Nice to have — usually related to front-end/visual tasks QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Milestone
0.55.x - Release ...

Comments

@srirambv
Copy link
Contributor

srirambv commented Jul 2, 2018

Description

Shields should not show badge when block count is 0

Steps to Reproduce

  1. Open a new tab
  2. Shows disabled shields icon but shows active 0 count

Actual result:

image

Expected result:

Should be similar to b-l. No badge count should be shown when nothing is blocked

Reproduces how often:

100%

Brave version (about:brave info)

e71fc40

Reproducible on current release:

Yes

Website problems only:

  • Does the issue gets fixed with Brave Shields disabled?
  • Does the issue reproduces on Chrome?

Additional Information

Follow up to #240
@srirambv srirambv added feature/shields The overall Shields feature in Brave. polish Nice to have — usually related to front-end/visual tasks browser-laptop-parity labels Jul 2, 2018
@srirambv srirambv added this to the Backlog milestone Jul 2, 2018
cezaraugusto added a commit to brave/brave-extension that referenced this issue Jul 2, 2018
@cezaraugusto
do not show badge text if there are no resources blocked
35d4150 
-
fix brave/brave-browser#470
@cezaraugusto cezaraugusto mentioned this issue Jul 2, 2018
Merged
@bbondy bbondy modified the milestones: Backlog, Releasable builds Jul 3, 2018
@bbondy bbondy added the QA/Yes label Aug 18, 2018
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Aug 28, 2018 •
edited by LaurenWags
Loading

Verified on

Brave 0.54.2 Chromium: 69.0.3497.42 (Official Build) dev (64-bit)
Revision 9c4613c66dfeb2b76ef6dd4b15884c15db3b4969-refs/branch-heads/3497@{#655}
OS Windows

Verification Passed on

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux

Verified passed with

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Mac OS X

@bbondy bbondy added the QA/Yes label Sep 27, 2018
@btlechowski btlechowski mentioned this issue Apr 4, 2019
Closed
This was referenced Apr 4, 2019
Open
Closed
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Apr 5, 2019
Closed
@srirambv srirambv mentioned this issue Apr 5, 2019
Closed
@AlexeyBarabash AlexeyBarabash mentioned this issue Apr 5, 2019
Closed
This was referenced Apr 5, 2019
Closed
Closed
@InternetJohnny InternetJohnny mentioned this issue Apr 9, 2019
Closed
This was referenced Apr 10, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cezaraugusto cezaraugusto

Labels
browser-laptop-parity feature/shields The overall Shields feature in Brave. polish Nice to have — usually related to front-end/visual tasks QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

do not show badge text if there are no resources blocked brave/brave-extension
5 participants
@bbondy @cezaraugusto @srirambv @LaurenWags @GeetaSarvadnya