"Complete" payout status is not showing green "Arrived" message banner

[LaurenWags]

Description

Found while testing #23429

When parameters endpoint returns complete (and the date is on or after the payment date), there is no green "Arrived" banner for ad grant. Green "Arrived" banner does not display until you successfully complete the captcha. This seems to indicate that the API isn't being utilized.

Steps to Reproduce

Pre-req: server should be set to return "complete" for payout status

1. Clean profile staging env
2. Enable Rewards
3. View an ad and redeem it with the server (cash in your payment token)
4. Close browser
5. Advance date to the 6th (day before my payout day)
6. I see the countdown banner as expected.
7. Close browser
8. Advance date to the 7th (or 8th, 9th, etc)

Repeat above for unverified rewards as well as verified user w/ a custodial wallet provider (Uphold, Gemini, bF)

Actual result:

No green "Arrived" banner on ads panel of brave://rewards, rewards panel, NTP widget

Expected result:

Green "Arrived" banner to show since the API is returning "complete"

Note - possibly the green "Arrived" banner should be removed from view if you complete a captcha? Mentioned by @Miyayes. Need to confirm - makes sense for it to do so in unverified case, but what happens if you have a custodian? does the banner just always display until "off" is returned from API?

Reproduces how often:

easily

Brave version (brave://version info)

Brave | 1.43.81 Chromium: 104.0.5112.102 (Official Build) (x86_64)
-- | --
Revision | 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS | macOS Version 12.5.1 (Build 21G83)

Version/Channel Information:

• Can you reproduce this issue with the current release? 1.42.x n/a, 1.43.x yes
• Can you reproduce this issue with the beta channel?
• Can you reproduce this issue with the nightly channel?

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @Miyayes @emerick @GeetaSarvadnya

[LaurenWags]

Added QA/Blocked label until uplifted to 1.43.x

[LaurenWags]

Can be tested with 1.43.84 and above.

[LaurenWags]

Verified with

Brave | 1.43.84 Chromium: 105.0.5195.68 (Official Build) (x86_64)
-- | --
Revision | ad13e82529051bac6a0e65f455e6d7a1e5fd7938-refs/branch-heads/5195@{#903}
OS | macOS Version 12.5.1 (Build 21G83)

1. For the below cases, confirmed when "complete" is returned from payoutStatus API, and it is on or after the payout date (ex. 7th in my case), and ad tokens were cashed in for the previous month, the "Arrived" message shows as expected:

Test Case details

Unverified/Anon - PASSED

When using an unverified/anon setup for rewards (no custodial provider):

• Ensured payout status is fetched correctly and ensured there is no crash in browser
• Ensured /parameters API endpoint is returning success response code 200 for payout status and ensured there are no error logs
• Ensured payment processing status is not triggered when payout status is set as "Complete" at the server side
• Ensured the "Arrived" message is shown in all expected places
• Ensured the "Arrived" message is shown based on payoutStatus returned from API (I did not need to send myself an Ad grant to get this message to show)

Example	Example	Example	Example

Logs for - /parameters

[ REQUEST ]
> URL: https://api.rewards.bravesoftware.com/v1/parameters
> Method: GET

........

[ RESPONSE - OnRequest ]
> Url: https://api.rewards.bravesoftware.com/v1/parameters
> Result: Success
> HTTP Code: 200
> Body: {"payoutStatus":{"unverified":"complete","uphold":"complete","gemini":"complete","bitflyer":"complete"},"custodianRegions":{"uphold":{"allow":["AU","AT","BE","CA","CO","DK","FI","HK","IE","IT","NL","NO","PT","SG","ES","SE","GB","US"],"block":[]},"gemini":{"allow":["AU","AT","BE","CA","CO","DK","FI","HK","IE","IT","NL","NO","PT","SG","ES","SE","GB","US"],"block":[]},"bitflyer":{"allow":["JP"],"block":[]}},"batRate":0.34679,"autocontribute":{"choices":[1,2,3,5,7,10,20],"defaultChoice":1},"tips":{"defaultTipChoices":[1.25,5,10.5],"defaultMonthlyChoices":[1.25,5,10.5]}}
[16048:259:0907/084118.259339:VERBOSE9:logging_util.cc(138)] 
[ RESPONSE HEADERS ]
> Url: https://api.rewards.bravesoftware.com/v1/parameters
[16048:259:0907/084118.262708:VERBOSE1:api_parameters.cc(90)] Params timer set for 13750 s

Gemini - PASSED

• Ensured payout status is fetched correctly and ensured there is no crash in browser
• Ensured /parameters API endpoint is returning success response code 200 for payout status and ensured there are no error logs
• Ensured payment processing status is not triggered when payout status is set as "Complete" at the server side
• Ensured the "Arrived" message is shown in all expected places
• Ensured the "Arrived" message is shown based on payoutStatus returned from API (I did not need to send myself an Ad grant to get this message to show)

Example	Example	Example	Example

Logs for - /parameters

[ REQUEST ]
> URL: https://api.rewards.bravesoftware.com/v1/parameters
> Method: GET

.......

[ RESPONSE - OnRequest ]
> Url: https://api.rewards.bravesoftware.com/v1/parameters
> Result: Success
> HTTP Code: 200
> Body: {"payoutStatus":{"unverified":"complete","uphold":"complete","gemini":"complete","bitflyer":"complete"},"custodianRegions":{"uphold":{"allow":["AU","AT","BE","CA","CO","DK","FI","HK","IE","IT","NL","NO","PT","SG","ES","SE","GB","US"],"block":[]},"gemini":{"allow":["AU","AT","BE","CA","CO","DK","FI","HK","IE","IT","NL","NO","PT","SG","ES","SE","GB","US"],"block":[]},"bitflyer":{"allow":["JP"],"block":[]}},"batRate":0.346438,"autocontribute":{"choices":[1,2,3,5,7,10,20],"defaultChoice":1},"tips":{"defaultTipChoices":[1.25,5,10.5],"defaultMonthlyChoices":[1.25,5,10.5]}}
[2777:259:0907/093600.188197:VERBOSE9:logging_util.cc(138)] 
[ RESPONSE HEADERS ]
> Url: https://api.rewards.bravesoftware.com/v1/parameters
[2777:259:0907/093600.192604:VERBOSE1:api_parameters.cc(90)] Params timer set for 11504 s

Uphold - PASSED

• Ensured payout status is fetched correctly and ensured there is no crash in browser
• Ensured /parameters API endpoint is returning success response code 200 for payout status and ensured there are no error logs
• Ensured payment processing status is not triggered when payout status is set as "Complete" at the server side
• Ensured the "Arrived" message is shown in all expected places
• Ensured the "Arrived" message is shown based on payoutStatus returned from API (I did not need to send myself an Ad grant to get this message to show)

Example	Example	Example	Example

Logs for - /parameters

[ REQUEST ]
> URL: https://api.rewards.bravesoftware.com/v1/parameters
> Method: GET

.......

[ RESPONSE - OnRequest ]
> Url: https://api.rewards.bravesoftware.com/v1/parameters
> Result: Success
> HTTP Code: 200
> Body: {"payoutStatus":{"unverified":"complete","uphold":"complete","gemini":"complete","bitflyer":"complete"},"custodianRegions":{"uphold":{"allow":["AU","AT","BE","CA","CO","DK","FI","HK","IE","IT","NL","NO","PT","SG","ES","SE","GB","US"],"block":[]},"gemini":{"allow":["AU","AT","BE","CA","CO","DK","FI","HK","IE","IT","NL","NO","PT","SG","ES","SE","GB","US"],"block":[]},"bitflyer":{"allow":["JP"],"block":[]}},"batRate":0.345569,"autocontribute":{"choices":[1,2,3,5,7,10,20],"defaultChoice":1},"tips":{"defaultTipChoices":[1.25,5,10.5],"defaultMonthlyChoices":[1.25,5,10.5]}}
[3509:259:0907/100853.240127:VERBOSE9:logging_util.cc(138)] 
[ RESPONSE HEADERS ]
> Url: https://api.rewards.bravesoftware.com/v1/parameters
[3509:259:0907/100853.242094:VERBOSE1:api_parameters.cc(90)] Params timer set for 11363 s

bitFlyer - PASSED

• Ensured payout status is fetched correctly and ensured there is no crash in browser
• Ensured /parameters API endpoint is returning success response code 200 for payout status and ensured there are no error logs
• Ensured payment processing status is not triggered when payout status is set as "Complete" at the server side
• Ensured the "Arrived" message is shown in all expected places
• Ensured the "Arrived" message is shown based on payoutStatus returned from API (I did not need to send myself an Ad grant to get this message to show)

Example	Example	Example	Example

Logs for - /parameters

[ REQUEST ]
> URL: https://api.rewards.bravesoftware.com/v1/parameters
> Method: GET

........

[ RESPONSE - OnRequest ]
> Url: https://api.rewards.bravesoftware.com/v1/parameters
> Result: Success
> HTTP Code: 200
> Body: {"payoutStatus":{"unverified":"complete","uphold":"complete","gemini":"complete","bitflyer":"complete"},"custodianRegions":{"uphold":{"allow":["AU","AT","BE","CA","CO","DK","FI","HK","IE","IT","NL","NO","PT","SG","ES","SE","GB","US"],"block":[]},"gemini":{"allow":["AU","AT","BE","CA","CO","DK","FI","HK","IE","IT","NL","NO","PT","SG","ES","SE","GB","US"],"block":[]},"bitflyer":{"allow":["JP"],"block":[]}},"batRate":0.344985,"autocontribute":{"choices":[1,2,3,5,7,10,20],"defaultChoice":1},"tips":{"defaultTipChoices":[1.25,5,10.5],"defaultMonthlyChoices":[1.25,5,10.5]}}
[4115:259:0907/102125.483204:VERBOSE9:logging_util.cc(138)] 
[ RESPONSE HEADERS ]
> Url: https://api.rewards.bravesoftware.com/v1/parameters
[4115:259:0907/102125.486059:VERBOSE1:api_parameters.cc(90)] Params timer set for 12073 s

2. For the below cases, confirmed when ads are cashed in/redeemed with the server and it is prior to payout date (ex. 1st thru 6th of month depending on location), the "countdown" message is displayed in the UI:

Test Case details

Unverified/Anon - PASSED

When using an unverified/anon setup for rewards (no custodial provider):

• Ensured countdown message is displayed 1st-6th of month (prior to payout date, your payout date may differ):

Example	Example	Example	Example

Gemini - PASSED

• Ensured countdown message is displayed 1st-6th of month (prior to payout date, your payout date may differ):

Example	Example	Example	Example

Uphold - PASSED

• Ensured countdown message is displayed 1st-6th of month (prior to payout date, your payout date may differ):

Example	Example	Example	Example

bitFlyer - PASSED

• Ensured countdown message is displayed 1st-6th of month (prior to payout date, your payout date may differ):

Example	Example	Example	Example

3. For the below cases, confirmed when "processing" is returned from payoutStatus API, and it is on or after the payout date (7th in my case), and ad tokens have been cashed in for the previous month, the processing message shows as expected:

Test Case details

Unverified/Anon - PASSED

When using an unverified/anon setup for rewards (no custodial provider):

• Ensured the "processing" message is shown in all expected places

Example	Example	Example	Example

Gemini - PASSED

• Ensured the "processing" message is shown in all expected places

Example	Example	Example	Example

Uphold - PASSED

• Ensured the "processing" message is shown in all expected places

Example	Example	Example	Example

bitFlyer - PASSED

• Ensured the "processing" message is shown in all expected places

Example	Example	Example	Example

4. For the below cases, confirmed when "off" is returned from payoutStatus API, and it is on or after the payout date (7th in my case), and ad tokens were cashed in for the previous month, no banners display in the UI:

Test Case details

Unverified/Anon - PASSED

When using an unverified/anon setup for rewards (no custodial provider):

• Ensured no banners are displayed in the UI

Example	Example	Example	Example

Gemini - PASSED

• Ensured no banners are displayed in the UI

Example	Example	Example	Example

Uphold - PASSED

• Ensured no banners are displayed in the UI

Example	Example	Example	Example

bitFlyer - PASSED

• Ensured no banners are displayed in the UI

Example	Example	Example	Example

5. For the below case, confirmed when "complete" or "processing" is returned from payoutStatus API, and it is on or after the payout date (ex. 7th in my case), and ad tokens were NOT cashed in for the previous month, no countdown, processing, or arrived messaging shows as there is no ad grant coming for this paymentID:

Test Case details

When using an unverified/anon setup for rewards (no custodial provider):

• Ensured no banners are displayed in the UI

Aug 30 - no ads redeemed with server	Sept 4 - no countdown banner	Sept 7 - no processing or arrived message

6. For the below cases, confirmed when various payout statues is returned from payoutStatus API (they're not all the same), and it is on or after the payout date (ex. 7th in my case), and ad tokens were cashed in for the previous month, the various reward types show the expected messaging:

Test Case details

{"unverified":"complete","uphold":"processing","gemini":"off","bitflyer":"complete"} - PASSED

For the above, all 4 were checked on the same day (Sept 9), all had ad tokens cashed in for previous month.
Confirmed each of the above showed the expected messaging (or no messaging if "off"):

Unverified/Anon	Uphold	Gemini	bitFlyer

Logs:

[ REQUEST ]
> URL: https://api.rewards.bravesoftware.com/v1/parameters
> Method: GET

.........

[ RESPONSE - OnRequest ]
> Url: https://api.rewards.bravesoftware.com/v1/parameters
> Result: Success
> HTTP Code: 200
> Body: {"payoutStatus":{"unverified":"complete","uphold":"processing","gemini":"off","bitflyer":"complete"},"custodianRegions":{"uphold":{"allow":["AU","AT","BE","CA","CO","DK","FI","HK","IE","IT","NL","NO","PT","SG","ES","SE","GB","US"],"block":[]},"gemini":{"allow":["AU","AT","BE","CA","CO","DK","FI","HK","IE","IT","NL","NO","PT","SG","ES","SE","GB","US"],"block":[]},"bitflyer":{"allow":["JP"],"block":[]}},"batRate":0.373245,"autocontribute":{"choices":[1,2,3,5,7,10,20],"defaultChoice":1},"tips":{"defaultTipChoices":[1.25,5,10.5],"defaultMonthlyChoices":[1.25,5,10.5]}}
[9782:259:0909/161306.952509:VERBOSE9:logging_util.cc(138)] 
[ RESPONSE HEADERS ]
> Url: https://api.rewards.bravesoftware.com/v1/parameters

[Uni-verse]

Verification completed on Samsung GS 21 on Android 12 using the following build(s):

1.43.86 Chromium: 105.0.5195.68 (Official Build) (64-bit) 
Revision	ad13e82529051bac6a0e65f455e6d7a1e5fd7938-refs/branch-heads/5195@{#903}
OS	Android 12; Build/SP1A.210812.016

Testing based on #24980 (comment)

1. For the below cases, confirmed when "complete" is returned from payoutStatus API, and it is on or after the payout date (ex. 7th in my case), and ad tokens were cashed in for the previous month, the "Arrived" message shows as expected:

Unverified/Anon - PASSED

When using an unverified/anon setup for rewards (no custodial provider):

• Ensured payout status is fetched correctly and ensured there is no crash in browser
• Ensured /parameters API endpoint is returning success response code 200 for payout status and ensured there are no error logs
• Ensured payment processing status is not triggered when payout status is set as "Complete" at the server side
• Ensured the "Arrived" message is shown in all expected places
• Ensured the "Arrived" message is shown based on payoutStatus returned from API (I did not need to send myself an Ad grant to get this message to show)

Logs:

10-01 20:05:46.182 26044 26044 V chromium: > Result: Success
10-01 20:05:46.182 26044 26044 V chromium: > HTTP Code: 200
10-01 20:05:46.182 26044 26044 V chromium: > Body: {"payoutStatus":{"unverified":"complete","uphold":"complete","gemini":"complete","bitflyer":"complete"},"custodianRegions":{"uphold":{"allow":["AU","AT","BE","CA","CO","DK","FI","HK","IE","IT","NL","NO","PT","SG","ES","SE","GB","US"],"block":[]},"gemini":{"allow":["AU","AT","BE","CA","CO","DK","FI","HK","IE","IT","NL","NO","PT","SG","ES","SE","GB","US"],"block":[]},"bitflyer":{"allow":["JP"],"block":[]}},"batRate":0.337382,"autocontribute":{"choices":[1,2,3,5,7,10,20],"defaultChoice":1},"tips":{"defaultTipChoices":[1.25,5,10.5],"defaultMonthlyChoices":[1.25,5,10.5]}}
10-01 20:05:46.182 26044 26044 V chromium: 
10-01 20:05:46.188 26044 26044 V chromium: [VERBOSE1:api_parameters.cc(90)] Params timer set for 11148 s

Gemini - PASSED

• Ensured payout status is fetched correctly and ensured there is no crash in browser
• Ensured /parameters API endpoint is returning success response code 200 for payout status and ensured there are no error logs
• Ensured payment processing status is not triggered when payout status is set as "Complete" at the server side
• Ensured the "Arrived" message is shown in all expected places
• Ensured the "Arrived" message is shown based on payoutStatus returned from API (I did not need to send myself an Ad grant to get this message to show)

Logs:

10-01 20:37:52.420 19048 19048 V chromium: > Url: https://api.rewards.bravesoftware.com/v1/parameters
10-01 20:37:52.420 19048 19048 V chromium: > Result: Success
10-01 20:37:52.420 19048 19048 V chromium: > HTTP Code: 200
10-01 20:37:52.420 19048 19048 V chromium: > Body: {"payoutStatus":{"unverified":"complete","uphold":"complete","gemini":"complete","bitflyer":"complete"},"custodianRegions":{"uphold":{"allow":["AU","AT","BE","CA","CO","DK","FI","HK","IE","IT","NL","NO","PT","SG","ES","SE","GB","US"],"block":[]},"gemini":{"allow":["AU","AT","BE","CA","CO","DK","FI","HK","IE","IT","NL","NO","PT","SG","ES","SE","GB","US"],"block":[]},"bitflyer":{"allow":["JP"],"block":[]}},"batRate":0.342049,"autocontribute":{"choices":[1,2,3,5,7,10,20],"defaultChoice":1},"tips":{"defaultTipChoices":[1.25,5,10.5],"defaultMonthlyChoices":[1.25,5,10.5]}}

Uphold - PASSED

• Ensured payout status is fetched correctly and ensured there is no crash in browser
• Ensured /parameters API endpoint is returning success response code 200 for payout status and ensured there are no error logs
• Ensured payment processing status is not triggered when payout status is set as "Complete" at the server side
• Ensured the "Arrived" message is shown in all expected places
• Ensured the "Arrived" message is shown based on payoutStatus returned from API (I did not need to send myself an Ad grant to get this message to show)

Logs:

09-07 19:11:06.485 15628 15628 V chromium: [ RESPONSE - OnRequest ]
09-07 19:11:06.485 15628 15628 V chromium: > Url: https://api.rewards.bravesoftware.com/v1/parameters
09-07 19:11:06.485 15628 15628 V chromium: > Result: Success
09-07 19:11:06.485 15628 15628 V chromium: > HTTP Code: 200
09-07 19:11:06.485 15628 15628 V chromium: > Body: {"payoutStatus":{"unverified":"complete","uphold":"complete","gemini":"complete","bitflyer":"complete"},"custodianRegions":{"uphold":{"allow":["AU","AT","BE","CA","CO","DK","FI","HK","IE","IT","NL","NO","PT","SG","ES","SE","GB","US"],"block":[]},"gemini":{"allow":["AU","AT","BE","CA","CO","DK","FI","HK","IE","IT","NL","NO","PT","SG","ES","SE","GB","US"],"block":[]},"bitflyer":{"allow":["JP"],"block":[]}},"batRate":0.338686,"autocontribute":{"choices":[1,2,3,5,7,10,20],"defaultChoice":1},"tips":{"defaultTipChoices":[1.25,5,10.5],"defaultMonthlyChoices":[1.25,5,10.5]}}

bitFlyer - PASSED

• Ensured payout status is fetched correctly and ensured there is no crash in browser
• Ensured /parameters API endpoint is returning success response code 200 for payout status and ensured there are no error logs
• Ensured payment processing status is not triggered when payout status is set as "Complete" at the server side
• Ensured the "Arrived" message is shown in all expected places
• Ensured the "Arrived" message is shown based on payoutStatus returned from API (I did not need to send myself an Ad grant to get this message to show)

Logs:

10-07 10:09:19.373 29430 29430 V chromium: [ RESPONSE - OnRequest ]
10-07 10:09:19.373 29430 29430 V chromium: > Url: https://api.rewards.bravesoftware.com/v1/parameters
10-07 10:09:19.373 29430 29430 V chromium: > Result: Success
10-07 10:09:19.373 29430 29430 V chromium: > HTTP Code: 200
10-07 10:09:19.373 29430 29430 V chromium: > Body: {"payoutStatus":{"unverified":"complete","uphold":"complete","gemini":"complete","bitflyer":"complete"},"custodianRegions":{"uphold":{"allow":["AU","AT","BE","CA","CO","DK","FI","HK","IE","IT","NL","NO","PT","SG","ES","SE","GB","US"],"block":[]},"gemini":{"allow":["AU","AT","BE","CA","CO","DK","FI","HK","IE","IT","NL","NO","PT","SG","ES","SE","GB","US"],"block":[]},"bitflyer":{"allow":["JP"],"block":[]}},"batRate":0.341287,"autocontribute":{"choices":[1,2,3,5,7,10,20],"defaultChoice":1},"tips":{"defaultTipChoices":[1.25,5,10.5],"defaultMonthlyChoices":[1.25,5,10.5]}}

Arrived Rewards (Gemini/Uphold/Anon)	Countdown message (Gemini/Uphold/Anon)	bitFlyer Arrival	bitFlyer Countdown message