Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button text is not visible in dark mode #25225

Closed
srirambv opened this issue Sep 6, 2022 · 5 comments · Fixed by brave/brave-core#15003
Closed

Button text is not visible in dark mode #25225

srirambv opened this issue Sep 6, 2022 · 5 comments · Fixed by brave/brave-core#15003
Assignees
@samartnik
Labels
bug feature/settings OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Platforms QA/Yes regression release-notes/include
Milestone
1.43.x - Release #4

Comments

@srirambv
Copy link
Contributor

srirambv commented Sep 6, 2022 •
edited
Loading

Description

Button text is not visible. Seems like a regression in CR105

Steps to reproduce

  1. Install 1.44.75 x64 beta build
  2. Open Menu -> Settings -> Brave Shields & privacy -> Clear browsing data
  3. Button text is not visible

Actual result

Clear.Browsing.Data.button.text.mp4

Impacted buttons

Clear data Add Address Add Card Install App shortucut
image image Can't take screenshot but has the same issue image

Expected result

Button text should be visible

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Phone
  • Android version: 12

Brave version

1.44.75

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @mkarolin @samartnik @Uni-verse @kjozwiak
@srirambv srirambv changed the title Button text is not visible Button text is not visible in dark mode Sep 6, 2022
@GeetaSarvadnya
Copy link

Reproduced the issue in Galaxy A5 ARM device version 11 - Bravemonarm.apk_1.44.75

@kjozwiak
Copy link
Member

kjozwiak commented Sep 6, 2022

Probably a good idea to get this one fixed in the 1.43.x maintenance release.

@samartnik samartnik self-assigned this Sep 6, 2022
@samartnik samartnik mentioned this issue Sep 6, 2022
Merged
25 tasks
@brave-builds brave-builds added this to the 1.45.x - Nightly milestone Sep 6, 2022
This was referenced Sep 7, 2022
Merged
Merged
@kjozwiak
Copy link
Member

kjozwiak commented Sep 7, 2022

The above will require 1.43.91 or higher for 1.43.x verification 👍

@srirambv
Copy link
Contributor Author

Verification passed on Oppo Reno 5 with Android 12 running 1.43.92 x64 build

  • Verified steps from issue description
  • Verified button text is visible on dark mode
  • Verified button text is still visible on light mode
Clear data Add address Install App Reset Permission

@srirambv
Copy link
Contributor Author

Verification passed on Samsung Tab A with Android 10 running 1.43.92 x64 build

  • Verified steps from issue description
  • Verified button text is visible on dark mode
  • Verified button text is still visible on light mode
Clear data Add address Install App Reset Permission
image image image image

@srirambv srirambv mentioned this issue Sep 13, 2022
Closed
@kjozwiak kjozwiak mentioned this issue Sep 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samartnik samartnik

Labels
bug feature/settings OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Platforms QA/Yes regression release-notes/include
Projects
None yet
Milestone
1.43.x - Release #4
Development

Successfully merging a pull request may close this issue.

[Android] Fix for button text color brave/brave-core
5 participants
@kjozwiak @srirambv @samartnik @GeetaSarvadnya @brave-builds