Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Fix for button text color #15003

Merged
merged 1 commit into from
Sep 6, 2022
Merged

Conversation

samartnik
Copy link
Contributor

@samartnik samartnik commented Sep 6, 2022

Resolves brave/brave-browser#25225

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@samartnik samartnik added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Sep 6, 2022
@samartnik samartnik added this to the 1.45.x - Nightly milestone Sep 6, 2022
@samartnik samartnik self-assigned this Sep 6, 2022
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@samartnik samartnik merged commit 79a8852 into master Sep 6, 2022
@samartnik samartnik deleted the android_button_text_color_fix branch September 6, 2022 22:38
brave-builds pushed a commit that referenced this pull request Sep 7, 2022
brave-builds pushed a commit that referenced this pull request Sep 7, 2022
@kjozwiak
Copy link
Member

kjozwiak commented Sep 7, 2022

Verification PASSED on Samsung S10+ running Android 12 using the following build(s):

Brave | 1.45.32 Chromium: 105.0.5195.102 (Official Build) canary (32-bit)
--- | ---
Revision | 4c16f5ffcc2da70ee2600d5db77bed423ac03a5a-refs/branch-heads/5195_55@{#4}
OS | Android 12; Build/SP1A.210812.016
Example Example Example
Screenshot_20220907-152139_Brave - Nightly Screenshot_20220907-152156_Brave - Nightly Screenshot_20220907-152231_Brave - Nightly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button text is not visible in dark mode
3 participants