Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images missing on Create new sync chain #2523

Closed
srirambv opened this issue Dec 13, 2018 · 4 comments
Closed

Images missing on Create new sync chain #2523

srirambv opened this issue Dec 13, 2018 · 4 comments

Comments

@srirambv
Copy link
Contributor

Description

Images missing on Create new sync chain on Linux

Steps to Reproduce

  1. Install 0.58.12
  2. Create a new sync chain
  3. On device selection screen, images are misssing

Actual result:

screenshot from 2018-12-13 17-30-02

Expected result:

Should show images as per spec

Reproduces how often:

Brave version (brave://version info)

Brave 0.58.12 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Linux

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    No Beta/Dev is still not on sync V2 UI

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
    NA
  • Is the issue reproducible on the latest version of Chrome?
    NA

Additional Information

cc: @brave/legacy_qa to verify on other platforms

@LaurenWags
Copy link
Member

Reproduces on macOS

Brave 0.58.12 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Mac OS X

screen shot 2018-12-13 at 8 51 21 am

@GeetaSarvadnya
Copy link

Reproduce on Windows '0.58.12`

Brave 0.58.12 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Windows

image

@LaurenWags LaurenWags changed the title Images missing on Create new sync chain on Linux Images missing on Create new sync chain Dec 13, 2018
@darkdh darkdh self-assigned this Dec 16, 2018
@cezaraugusto
Copy link
Contributor

fixed by the uplift of brave/brave-core@a35a3e3. doesn't happen in v0.58.14.

@btlechowski
Copy link

btlechowski commented Dec 17, 2018

Verification passed on

Brave 0.58.14 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Windows 7

Used STR from OP.

image

Verified passed with

Brave 0.58.14 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Mac OS X

screen shot 2018-12-17 at 4 57 03 pm

Verification PASSED on Ubuntu 18.04.1 x64 using the following build:

Brave 0.58.14 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Linux

screen shot 2018-12-17 at 11 43 33 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants